-
Notifications
You must be signed in to change notification settings - Fork 49
Comparing changes
Open a pull request
base repository: moby/sys
base: signal/v0.6.0
head repository: moby/sys
compare: signal/v0.7.0
- 16 commits
- 9 files changed
- 4 contributors
Commits on Jan 5, 2022
-
Add lcow supported signals to windows signal map
Signed-off-by: Kathryn Baldauf <[email protected]>
Kathryn Baldauf committedJan 5, 2022 Configuration menu - View commit details
-
Copy full SHA for 60ec0fe - Browse repository at this point
Copy the full SHA 60ec0feView commit details
Commits on Jan 14, 2022
-
mountinfo: unify mountedBy checks
Instead of copy/pasting the code to check individual mountedBy* implementations, add a list and a loop to check them. The only special thing is, we have to check if the name of the function being tested is "mountedByStat", to skip erroring out on bind mounts. Otherwise the code is the same. Signed-off-by: Kir Kolyshkin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 791cf7a - Browse repository at this point
Copy the full SHA 791cf7aView commit details -
mount: fix unused/deadcode warnings on Mac
Since commit 7a52162 Mount is not implemented on Darwin, so mount() is left unused. Also, mount errors are only used from mount(), and thus are not used on Darwin. This fixes a bunch of warnings from "unused" and "deadcode" lints. Signed-off-by: Kir Kolyshkin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f9e0a7d - Browse repository at this point
Copy the full SHA f9e0a7dView commit details
Commits on Jan 18, 2022
-
Merge pull request #101 from kolyshkin/darwin-deadcode
mount: fix unused/deadcode warnings on Mac
Configuration menu - View commit details
-
Copy full SHA for 0ef20af - Browse repository at this point
Copy the full SHA 0ef20afView commit details
Commits on Jan 27, 2022
-
Merge pull request #98 from katiewasnothere/windows_lcow_signals
Add lcow supported signals to windows signal map
Configuration menu - View commit details
-
Copy full SHA for 74ec3fe - Browse repository at this point
Copy the full SHA 74ec3feView commit details
Commits on Feb 3, 2022
-
mountinfo: improve Mounted doc
Fixes: dbd468b Signed-off-by: Kir Kolyshkin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4c08076 - Browse repository at this point
Copy the full SHA 4c08076View commit details -
MountedFast is a method of detecting a mount point without reading mountinfo from procfs. A caller can only trust the result if no error and sure == true are returned. Otherwise, other methods (e.g. parsing /proc/mounts) have to be used. If unsure, use Mounted instead (which uses MountedFast, but falls back to parsing mountinfo if needed). If a non-existent path is specified, an appropriate error (rather than "not mounted") is returned. In case the caller is not interested in this particular error, it should be handled separately using e.g. errors.Is(err, os.ErrNotExist). This function is only available on Linux. The implementation mostly relies on openat2(2) syscall, available since Linux kernel v5.6. On older kernels, this uses stat(2) syscall which can reliably detect normal (but not bind) mounts. Signed-off-by: Kir Kolyshkin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 88ece65 - Browse repository at this point
Copy the full SHA 88ece65View commit details -
mountinfo: mounted_linux_test: nits
1. Do not compare booleans to false and true. 2. Since there are only two values, no sense in printing the actual value. Signed-off-by: Kir Kolyshkin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3494465 - Browse repository at this point
Copy the full SHA 3494465View commit details -
mountinfo: TestMountedBy: rm exp
For clarity. Signed-off-by: Kir Kolyshkin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9742587 - Browse repository at this point
Copy the full SHA 9742587View commit details -
mountinfo: add tests for MountedFast
Signed-off-by: Kir Kolyshkin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 303f101 - Browse repository at this point
Copy the full SHA 303f101View commit details -
mountinfo: add TestMountedRoot
Test both MountedFast and Mounted. Signed-off-by: Kir Kolyshkin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5d09d69 - Browse repository at this point
Copy the full SHA 5d09d69View commit details -
Merge pull request #100 from kolyshkin/mounted-fast
mountinfo: add MountedFast
Configuration menu - View commit details
-
Copy full SHA for d01e595 - Browse repository at this point
Copy the full SHA d01e595View commit details -
mount: bump mountinfo to v0.6.0
Signed-off-by: Kir Kolyshkin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e1c5b38 - Browse repository at this point
Copy the full SHA e1c5b38View commit details -
Merge pull request #103 from kolyshkin/mount-bump-mountinfo-0.6
mount: bump mountinfo to v0.6.0
Configuration menu - View commit details
-
Copy full SHA for d4611de - Browse repository at this point
Copy the full SHA d4611deView commit details
Commits on Feb 5, 2022
-
Makefile: rm .SHELLFLAGS, add set -e
Apparently GHA CI Mac OS X environment uses old GNU Make (v3.81) which does not yes support .SHELLFLAGS (added by commit 8589e2e). Since we call a few commands (under "for") from the make target, intermediate failures are ignored unless "-e" shell option is set (or explicit "&&" is used, which is not possible to do in "for"). Example: for cmd in false true; do $cmd; done This code succeeds (has exit code of 0), unless "set -e" is set, because the last command executed is "true" with the exit code of 0. Use explicit "set -e" where needed. While at it, also add "-u" to catch possible uses of uninitialized variables. Also, replace && with ; for multiple commands. Technically this is not required for the fix, but since having set -e results in implicit &&, there is no need to have && explicitly. In other words, this change is more like a reminder that we do not have to use && here. Fixes: 8589e2e Signed-off-by: Kir Kolyshkin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b128335 - Browse repository at this point
Copy the full SHA b128335View commit details
Commits on Feb 15, 2022
-
Merge pull request #105 from kolyshkin/fix-mac-ci
Makefile: rm .SHELLFLAGS, add set -e
Configuration menu - View commit details
-
Copy full SHA for b8d8fab - Browse repository at this point
Copy the full SHA b8d8fabView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff signal/v0.6.0...signal/v0.7.0