Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: moby/sys
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: mountinfo/v0.5.0
Choose a base ref
...
head repository: moby/sys
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: mountinfo/v0.6.0
Choose a head ref
  • 14 commits
  • 8 files changed
  • 5 contributors

Commits on Nov 5, 2021

  1. mount: update github.com/moby/sys/mountinfo v0.5.0

    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    thaJeztah committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    bdd898e View commit details
    Browse the repository at this point in the history
  2. Merge pull request #94 from thaJeztah/bump_mountinfo

    mount: update github.com/moby/sys/mountinfo v0.5.0
    thaJeztah authored Nov 5, 2021
    Configuration menu
    Copy the full SHA
    03b9f8d View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. Add lcow supported signals to windows signal map

    Signed-off-by: Kathryn Baldauf <[email protected]>
    Kathryn Baldauf committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    60ec0fe View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2022

  1. mountinfo: unify mountedBy checks

    Instead of copy/pasting the code to check individual mountedBy*
    implementations, add a list and a loop to check them.
    
    The only special thing is, we have to check if the name of the function
    being tested is "mountedByStat", to skip erroring out on bind mounts.
    Otherwise the code is the same.
    
    Signed-off-by: Kir Kolyshkin <[email protected]>
    kolyshkin committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    791cf7a View commit details
    Browse the repository at this point in the history
  2. mount: fix unused/deadcode warnings on Mac

    Since commit 7a52162 Mount is not implemented on Darwin, so
    mount() is left unused.
    
    Also, mount errors are only used from mount(), and thus are not used on
    Darwin.
    
    This fixes a bunch of warnings from "unused" and "deadcode" lints.
    
    Signed-off-by: Kir Kolyshkin <[email protected]>
    kolyshkin committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    f9e0a7d View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2022

  1. Merge pull request #101 from kolyshkin/darwin-deadcode

    mount: fix unused/deadcode warnings on Mac
    thaJeztah authored Jan 18, 2022
    Configuration menu
    Copy the full SHA
    0ef20af View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2022

  1. Merge pull request #98 from katiewasnothere/windows_lcow_signals

    Add lcow supported signals to windows signal map
    thaJeztah authored Jan 27, 2022
    Configuration menu
    Copy the full SHA
    74ec3fe View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2022

  1. mountinfo: improve Mounted doc

    Fixes: dbd468b
    Signed-off-by: Kir Kolyshkin <[email protected]>
    kolyshkin committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    4c08076 View commit details
    Browse the repository at this point in the history
  2. mountinfo: add MountedFast

    MountedFast is a method of detecting a mount point without reading
    mountinfo from procfs. A caller can only trust the result if no error
    and sure == true are returned. Otherwise, other methods (e.g. parsing
    /proc/mounts) have to be used. If unsure, use Mounted instead (which
    uses MountedFast, but falls back to parsing mountinfo if needed).
    
    If a non-existent path is specified, an appropriate error (rather than
    "not mounted") is returned. In case the caller is not interested in this
    particular error, it should be handled separately using e.g.
    errors.Is(err, os.ErrNotExist).
    
    This function is only available on Linux. The implementation mostly
    relies on openat2(2) syscall, available since Linux kernel v5.6.
    On older kernels, this uses stat(2) syscall which can reliably
    detect normal (but not bind) mounts.
    
    Signed-off-by: Kir Kolyshkin <[email protected]>
    kolyshkin committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    88ece65 View commit details
    Browse the repository at this point in the history
  3. mountinfo: mounted_linux_test: nits

    1. Do not compare booleans to false and true.
    
    2. Since there are only two values, no sense in printing the actual value.
    
    Signed-off-by: Kir Kolyshkin <[email protected]>
    kolyshkin committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    3494465 View commit details
    Browse the repository at this point in the history
  4. mountinfo: TestMountedBy: rm exp

    For clarity.
    
    Signed-off-by: Kir Kolyshkin <[email protected]>
    kolyshkin committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    9742587 View commit details
    Browse the repository at this point in the history
  5. mountinfo: add tests for MountedFast

    Signed-off-by: Kir Kolyshkin <[email protected]>
    manugupt1 authored and kolyshkin committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    303f101 View commit details
    Browse the repository at this point in the history
  6. mountinfo: add TestMountedRoot

    Test both MountedFast and Mounted.
    
    Signed-off-by: Kir Kolyshkin <[email protected]>
    kolyshkin committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    5d09d69 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #100 from kolyshkin/mounted-fast

    mountinfo: add MountedFast
    thaJeztah authored Feb 3, 2022
    Configuration menu
    Copy the full SHA
    d01e595 View commit details
    Browse the repository at this point in the history
Loading