Use Aliases from service Network Attachment Config in Task Network Attachment#974
Merged
aluzzardi merged 1 commit intomoby:masterfrom Jun 15, 2016
Merged
Use Aliases from service Network Attachment Config in Task Network Attachment#974aluzzardi merged 1 commit intomoby:masterfrom
aluzzardi merged 1 commit intomoby:masterfrom
Conversation
Contributor
Author
|
ping @aluzzardi @mrjana |
Contributor
Author
|
@aluzzardi this PR doesn't cover the indexing work that you are concentrating on. |
Current coverage is 54.03%@@ master #974 diff @@
==========================================
Files 75 75
Lines 11414 11412 -2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 6174 6166 -8
- Misses 4368 4370 +2
- Partials 872 876 +4
|
| // List of IPv4/IPv6 addresses that are assigned to the object | ||
| // as part of getting attached to this network. | ||
| repeated string addresses = 2; | ||
| // List of aliases by which a task is resolved in a network |
Contributor
There was a problem hiding this comment.
Please add a space above this line.
Contributor
|
Are these aliases for the individual task instances or the service itself? |
Contributor
Author
|
these are for the service for each network attachment. That will get translated into the DNS resolution alias for the VIP that powers the service / task. |
…tachment Signed-off-by: Madhu Venugopal <[email protected]>
Contributor
|
LGTM |
Member
|
/cc @stevvooe |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, the alias config in network attachment from Service Spec is copied to task's Network attachment. Hence the executor can make use of it to provide proper aliasing support.
Signed-off-by: Madhu Venugopal [email protected]