Add support for health start interval#3142
Merged
dperny merged 2 commits intomoby:masterfrom Jul 13, 2023
Merged
Conversation
This is needed for the next commit which uses the new `StartInterval` health config field. Signed-off-by: Brian Goff <[email protected]>
This is a new option in the docker API to set the interval health-checks are run during the start period. Signed-off-by: Brian Goff <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3142 +/- ##
===========================================
+ Coverage 0 61.67% +61.67%
===========================================
Files 0 155 +155
Lines 0 31144 +31144
===========================================
+ Hits 0 19207 +19207
- Misses 0 10393 +10393
- Partials 0 1544 +1544 |
This was referenced Jul 6, 2023
Collaborator
|
LGTM. Will, of course, need changes in moby/moby in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was added in moby/moby#40894.
Allows configuring a separate interval to run healthchecks at during the start period.
For instance after a service is healthy a healthcheck may only need to run once per 5 minutes but this can cause unneeded delays detecting when the task is healthy and adding it to the load balancer.