Fix a possible deadlock in the log broker#3006
Merged
Merged
Conversation
Contributor
|
@dperny |
Fixes a case where certain situations in the logbroker can create a deadlock. Fixes moby/moby#42314. Signed-off-by: Drew Erny <[email protected]>
dperny
force-pushed
the
fix-logbroker-deadlock
branch
from
June 11, 2021 16:33
dfa1571 to
21ba4a1
Compare
Codecov Report
@@ Coverage Diff @@
## master #3006 +/- ##
==========================================
- Coverage 60.88% 60.78% -0.10%
==========================================
Files 142 142
Lines 20293 20296 +3
==========================================
- Hits 12355 12337 -18
- Misses 6474 6496 +22
+ Partials 1464 1463 -1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a case where certain situations in the logbroker can create a deadlock. Fixes moby/moby#42314.
@xinfengliu, does this seem correct to you?