Skip to content

Conversation

@Alvise88
Copy link
Contributor

@Alvise88 Alvise88 commented Oct 15, 2020

Align protobuf with moby/moby project

Signed-off-by: Alvise Vitturi [email protected]

@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #2985 into master will decrease coverage by 1.06%.
The diff coverage is 22.48%.

@@            Coverage Diff             @@
##           master    #2985      +/-   ##
==========================================
- Coverage   61.77%   60.70%   -1.07%     
==========================================
  Files         142      142              
  Lines       23005    20286    -2719     
==========================================
- Hits        14211    12315    -1896     
+ Misses       7303     6501     -802     
+ Partials     1491     1470      -21     

@thaJeztah
Copy link
Member

I think #2957 is also updating this one (haven't checked if it's the same version though)

@Alvise88
Copy link
Contributor Author

I think #2957 is also updating this one (haven't checked if it's the same version though)

Yes, the same version

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! looks like there was a potential security issue in v1.3.1, so I opened a follow-up (including the commits from this PR) in #3002

to keep changes minimal, I waiting with the go.mod change until after this and merge this and #3002 first.

LGTM

@thaJeztah
Copy link
Member

@dperny @tonistiigi @AkihiroSuda ptal

@dperny dperny merged commit 4b7bd25 into moby:master Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants