Skip to content

Bump Golang 1.13.10#2943

Closed
thaJeztah wants to merge 1 commit intomoby:masterfrom
thaJeztah:bump_golang_1.13.10
Closed

Bump Golang 1.13.10#2943
thaJeztah wants to merge 1 commit intomoby:masterfrom
thaJeztah:bump_golang_1.13.10

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Apr 14, 2020

supersedes #2912
closes #2912

go1.13.10 (released 2020/04/08) includes fixes to the go command, the runtime,
os/exec, and time packages. See the Go 1.13.10 milestone on the issue tracker
for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.13.10+label%3ACherryPickApproved

@thaJeztah
Copy link
Member Author

thaJeztah commented Apr 14, 2020

Hmm... interesting; getting a panic on Go 1.13;

protoc -I.:/home/circleci/.go_workspace/src/github.com/docker/swarmkit/vendor/github.com/gogo/protobuf:/home/circleci/.go_workspace/src/github.com/docker/swarmkit/vendor:/home/circleci/.go_workspace/src:/usr/local/go_workspace/src:/usr/local/include --include_imports --descriptor_set_out=/tmp/descriptors.pb-396182527 --gogoswarm_out=plugins=grpc+deepcopy+storeobject+raftproxy+authenticatedwrapper,import_path=github.com/docker/swarmkit/api,Mgogoproto/gogo.proto=github.com/gogo/protobuf/gogoproto,Mgoogle/protobuf/any.proto=github.com/gogo/protobuf/types,Mgoogle/protobuf/descriptor.proto=github.com/gogo/protobuf/protoc-gen-gogo/descriptor,Mgoogle/protobuf/duration.proto=github.com/gogo/protobuf/types,Mgoogle/protobuf/field_mask.proto=github.com/gogo/protobuf/types,Mgoogle/protobuf/timestamp.proto=github.com/gogo/protobuf/types,Mgoogle/protobuf/wrappers.proto=github.com/gogo/protobuf/types:/home/circleci/.go_workspace/src /home/circleci/.go_workspace/src/github.com/docker/swarmkit/api/ca.proto /home/circleci/.go_workspace/src/github.com/docker/swarmkit/api/control.proto /home/circleci/.go_workspace/src/github.com/docker/swarmkit/api/dispatcher.proto /home/circleci/.go_workspace/src/github.com/docker/swarmkit/api/health.proto /home/circleci/.go_workspace/src/github.com/docker/swarmkit/api/logbroker.proto /home/circleci/.go_workspace/src/github.com/docker/swarmkit/api/objects.proto /home/circleci/.go_workspace/src/github.com/docker/swarmkit/api/raft.proto /home/circleci/.go_workspace/src/github.com/docker/swarmkit/api/resource.proto /home/circleci/.go_workspace/src/github.com/docker/swarmkit/api/snapshot.proto /home/circleci/.go_workspace/src/github.com/docker/swarmkit/api/specs.proto /home/circleci/.go_workspace/src/github.com/docker/swarmkit/api/types.proto /home/circleci/.go_workspace/src/github.com/docker/swarmkit/api/watch.proto
/usr/local/go_workspace/src: warning: directory does not exist.
panic: protobuf tag not enough fields in FileDescriptorSet.state: 

goroutine 1 [running]:
github.com/gogo/protobuf/proto.(*unmarshalInfo).computeUnmarshalInfo(0xc000098820)
	/home/circleci/.go_workspace/src/github.com/gogo/protobuf/proto/table_unmarshal.go:341 +0x17fb
github.com/gogo/protobuf/proto.(*unmarshalInfo).unmarshal(0xc000098820, 0xc000092980, 0xc000262000, 0x11064, 0x11264, 0x40c338, 0x20)
	/home/circleci/.go_workspace/src/github.com/gogo/protobuf/proto/table_unmarshal.go:138 +0xe13
github.com/gogo/protobuf/proto.(*InternalMessageInfo).Unmarshal(0xc00007f300, 0x7b04e0, 0xc000092980, 0xc000262000, 0x11064, 0x11264, 0xc000092901, 0x0)
	/home/circleci/.go_workspace/src/github.com/gogo/protobuf/proto/table_unmarshal.go:63 +0x66
github.com/gogo/protobuf/proto.(*Buffer).Unmarshal(0xc000109440, 0x7b04e0, 0xc000092980, 0x0, 0x0)
	/home/circleci/.go_workspace/src/github.com/gogo/protobuf/proto/decode.go:424 +0x1ec
github.com/gogo/protobuf/proto.Unmarshal(0xc000262000, 0x11064, 0x11264, 0x7b04e0, 0xc000092980, 0x0, 0x0)
	/home/circleci/.go_workspace/src/github.com/gogo/protobuf/proto/decode.go:342 +0x170
main.readDesc(0xc0000a8c40, 0x1d, 0x0, 0x1, 0x1)
	/home/circleci/.go_workspace/src/github.com/stevvooe/protobuild/descriptors.go:96 +0x9e
main.main()
	/home/circleci/.go_workspace/src/github.com/stevvooe/protobuild/main.go:218 +0x1819
make: *** [protos] Error 2

Exited with code exit status 2

@thaJeztah
Bump Golang 1.13.10
36188de 
go1.13.10 (released 2020/04/08) includes fixes to the go command, the runtime,
os/exec, and time packages. See the Go 1.13.10 milestone on the issue tracker
for details:

https://github.com/golang/go/issues?q=milestone%3AGo1.13.10+label%3ACherryPickApproved

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the bump_golang_1.13.10 branch from 7085c7e to 36188de Compare April 14, 2020 20:34
@Alvise88 Alvise88 mentioned this pull request Oct 12, 2020
Closed
@thaJeztah thaJeztah mentioned this pull request Jun 5, 2021
Merged
@dperny dperny closed this in #3004 Jun 8, 2021
@thaJeztah thaJeztah deleted the bump_golang_1.13.10 branch June 8, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@thaJeztah