Remove t.Log from mock task controller#2919
Merged
dperny merged 1 commit intomoby:masterfrom Dec 30, 2019
Merged
Conversation
Previous, worker_test.go included a call to t.Log in the mock task controller. This presented a problem: because goroutines spawned by a test are not exited when the test completes, any holdover goroutines, like the one spawned to close the task controller, live on. This creates a problem when that goroutine calls t.Log on a test that has already completed. This t.Log call doesn't add enough information to bother worrying about. Further, these goroutines, though they may outlive the test, don't actually affect anything or matter, so there's no rush to fix the test to ensure all goroutines exit. Signed-off-by: Drew Erny <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2919 +/- ##
==========================================
+ Coverage 61.62% 61.88% +0.26%
==========================================
Files 139 139
Lines 22615 22615
==========================================
+ Hits 13936 13995 +59
+ Misses 7194 7134 -60
- Partials 1485 1486 +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous, worker_test.go included a call to t.Log in the mock task controller. This presented a problem: because goroutines spawned by a test are not exited when the test completes, any holdover goroutines, like the one spawned to close the task controller, live on. This creates a problem when that goroutine calls t.Log on a test that has already completed.
This t.Log call doesn't add enough information to bother worrying about. Further, these goroutines, though they may outlive the test, don't actually affect anything or matter, so there's no rush to fix the test to ensure all goroutines exit.
This ought to fix a frequently observed test flake.