[WIP RFC] agent/reconcileTaskState: wait for closeManager#2906
Closed
kolyshkin wants to merge 1 commit intomoby:masterfrom
Closed
[WIP RFC] agent/reconcileTaskState: wait for closeManager#2906kolyshkin wants to merge 1 commit intomoby:masterfrom
kolyshkin wants to merge 1 commit intomoby:masterfrom
Conversation
Since commit be528e8 ("Bump Golang 1.12.9") test suite panics: > panic: Log in goroutine after TestWorkerUpdate has completed > > goroutine 1175 [running]: > testing.(*common).logDepth(0xc00019a100, 0xc0000396a0, 0x1d, 0x3) > /usr/local/go/src/testing/testing.go:634 +0x51a > testing.(*common).log(...) > /usr/local/go/src/testing/testing.go:614 > testing.(*common).Log(0xc00019a100, 0xc00006fb00, 0x1, 0x1) > /usr/local/go/src/testing/testing.go:642 +0x79 > github.com/docker/swarmkit/agent.(*mockTaskController).Remove(0xc00020a780, 0x13b6f40, 0xc0000b4010, 0x13b6f40, 0xc0000b4010) > /home/circleci/.go_workspace/src/github.com/docker/swarmkit/agent/worker_test.go:604 +0x8e > github.com/docker/swarmkit/agent.reconcileTaskState.func1(0xc0004dac60) > /home/circleci/.go_workspace/src/github.com/docker/swarmkit/agent/worker.go:270 +0x137 > created by github.com/docker/swarmkit/agent.reconcileTaskState > /home/circleci/.go_workspace/src/github.com/docker/swarmkit/agent/worker.go:313 +0x1a6f > FAIL github.com/docker/swarmkit/agent 4.244s > This is an attempt to fix this. Signed-off-by: Kir Kolyshkin <[email protected]>
Contributor
Author
|
I don't remember where I was going with this, so closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since PR #2880 the test suite always panics:
This is an attempt to fix this.