Revert "Make Service.UpdateStatus non-ambiguous"#2862
Merged
dperny merged 1 commit intomoby:masterfrom May 29, 2019
Merged
Conversation
This reverts commit 171d814. See moby#2861. This change broke progress bars for service scale up. Signed-off-by: Drew Erny <[email protected]>
Member
|
Thank @dperny ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Revert #2804 for reasons outlined in #2861.
- How I did it
I ran
git revert 171d814, but then realized I forgot to add--signoff, so I emptied the commit message to abort the commit. Then, I made this same mistake 2 more times in a row. I am not a clever man./cc @thaJeztah
Additionally, this change will be backported to 19.03