Refactor condition in restart supervisor#2805
Merged
anshulpundir merged 1 commit intomoby:masterfrom Jan 14, 2019
Merged
Conversation
Small change to refactor a condition in the restart supervisor's shouldRestart method. The old condition made my brain hurt. This should make it easier for everyone to understand. Signed-off-by: Drew Erny <[email protected]>
anshulpundir
approved these changes
Jan 14, 2019
Contributor
|
LGTM, minor refactor, good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small change to refactor a condition in the restart supervisor's shouldRestart method. The old condition made my brain hurt. This should make it easier for everyone to understand.
Skipping the usual pull request boilerplate because this is such a tiny refactor with no user-facing impact, which passes the unit tests.