Include old error-message for backward compatibility#2797
Merged
dperny merged 1 commit intomoby:masterfrom Jan 2, 2019
Merged
Conversation
Commit 2061af7 fixed the API returning incorrect status-codes, but also changed the error message for conflicting service-names to be in line with other objects (secrets, configs); "service XX already exists". Unfortunately, there are existing consumers of the API that perform string-matching, and changing the error-message resulted in a breaking change. This patch prepends the `ErrNameConflict` error-message to the error-message, so that those consumers still find the original message, but preserves the enhancement made in 2061af7 (inclusion of the conflicting service name). With this patch applied, the error message will look like this; name conflicts with an existing object: service myservice already exists Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
wsong
approved these changes
Dec 28, 2018
Codecov Report
@@ Coverage Diff @@
## master #2797 +/- ##
==========================================
+ Coverage 61.93% 61.99% +0.06%
==========================================
Files 137 137
Lines 22126 22126
==========================================
+ Hits 13703 13717 +14
+ Misses 6940 6927 -13
+ Partials 1483 1482 -1 |
seemethere
approved these changes
Dec 28, 2018
Collaborator
|
Yeah, LGTM. |
This was referenced Jan 7, 2019
|
is this the end of this PR or do we plan to move forward to the new error-message again eventually? If we will move forward, what do we do to ensure it does not break anything when we are ready to move forward? Thank you :) |
Member
Author
|
@anthonyleungdocker there's a test in place here to check it contains the expected error, but in the long run; this change will allow using the actual type of error instead of having to perform string-machine; moby/moby#38467 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 2061af7 (#2779) fixed the API returning incorrect status codes, but also changed the error message for conflicting service-names to be in line with other objects (secrets, configs); "service XX already exists".
Unfortunately, there are existing consumers of the API that perform string-matching, and changing the error-message resulted in a breaking change.
This patch prepends the
ErrNameConflicterror-message to the error-message, so that those consumers still find the original message, but preserves the enhancement made in 2061af7 (inclusion of the conflicting service name).With this patch applied, the error message will look like this;
- Description for the changelog