Support the init flag for container spec#2386
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2386 +/- ##
==========================================
- Coverage 60.37% 60.37% -0.01%
==========================================
Files 128 128
Lines 26260 26266 +6
==========================================
+ Hits 15855 15857 +2
+ Misses 9010 9002 -8
- Partials 1395 1407 +12 |
| }}, | ||
| }, | ||
| } | ||
| expected := (*bool)(nil) |
api/specs.proto
Outdated
| // is considered unhealthy after `Retries` number of consecutive failures. | ||
| HealthConfig healthcheck = 16; | ||
|
|
||
| // Run a custom init inside the container, if null, use the daemon's configured settings |
There was a problem hiding this comment.
Please follow the surrounding doc style. The comment should start with the name of the field // Init ....
Also, please this field up before tty.
api/specs.proto
Outdated
| // task will exit and a new task will be rescheduled elsewhere. A container | ||
| // is considered unhealthy after `Retries` number of consecutive failures. | ||
| HealthConfig healthcheck = 16; | ||
| HealthConfig healthcheck = 16; |
There was a problem hiding this comment.
Please remove the trailing whitespace.
|
Thanks. The only thing I think this is missing now is an update to the |
|
The api.pb.txt is auto-generated, but I don't know the process for commit. Just commit it with code changes or it is periodically updated by collabrators? |
|
It's committed with code changes. |
|
Done |
|
LGTM Thanks for getting this updated! |
|
Conflict happens. Need a rebase though. @denverdino |
Signed-off-by: Li Yi <[email protected]>
|
@allencloud thx and rebased |
|
@aaronlehmann Any comments on that? Thanks |
5 participants
Signed-off-by: Li Yi [email protected]
Add the optional init flag in container spec for init feature since Docker v1.13
Refine #2350, using BoolValue for init flag