Add StopSignal to ContainerSpec for --stop-signal#1924
Merged
yongtang merged 1 commit intomoby:masterfrom Feb 16, 2017
Merged
Conversation
This was referenced Feb 6, 2017
thaJeztah
approved these changes
Feb 9, 2017
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM (not a maintainer here)
Collaborator
|
LGTM |
1 similar comment
Collaborator
|
LGTM |
Member
|
@yongtang needs a rebase 👼 |
Member
|
LGTM, needs rebase :) |
This fix adds `StopSignal` to `ContainerSpec` so that it is possible to implement `--stop-signal` for `docker service create` and `docker service update`. Signed-off-by: Yong Tang <[email protected]>
yongtang
force-pushed
the
25696-stop-signal
branch
from
6b43b38 to
2167d44
Compare
Codecov Report
@@ Coverage Diff @@
## master #1924 +/- ##
==========================================
+ Coverage 54.35% 54.44% +0.08%
==========================================
Files 108 108
Lines 18586 18587 +1
==========================================
+ Hits 10102 10119 +17
+ Misses 7252 7240 -12
+ Partials 1232 1228 -4Continue to review full report at Codecov.
|
Member
Author
|
Sorry missed the notification on this PR :) The PR has been rebased and test passed. Merging... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix tries to address the issue raised in moby/moby#25696 where it was not possible to specify
--stop-signalfordocker service createanddocker service update, in order to use specific signal to stop the container.This fix adds
StopSignaltoContainerSpecso that it is possible to specify--stop-signalforservice updateandservice createRelated docker PR is moby/moby#30754
Signed-off-by: Yong Tang [email protected]