[encryption] Fix WAL directory manipulation in windows#1740
Merged
aaronlehmann merged 1 commit intomoby:masterfrom Nov 10, 2016
Merged
[encryption] Fix WAL directory manipulation in windows#1740aaronlehmann merged 1 commit intomoby:masterfrom
aaronlehmann merged 1 commit intomoby:masterfrom
Conversation
cyli
force-pushed
the
fix-raft-storage-windows
branch
from
7bbdd60 to
91cadbf
Compare
Current coverage is 55.13% (diff: 16.66%)@@ master #1740 diff @@
==========================================
Files 101 101
Lines 16497 16499 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 9086 9097 +11
+ Misses 6280 6266 -14
- Partials 1131 1136 +5
|
…se wal.Create fails in windows. Signed-off-by: cyli <[email protected]>
cyli
force-pushed
the
fix-raft-storage-windows
branch
from
91cadbf to
e9cea3a
Compare
Collaborator
|
LGTM |
1 similar comment
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes bugs introduced in #1598 in windows:
wal.Createwill not be able to rename