api: new mount type "introspection"#1642
Closed
AkihiroSuda wants to merge 1 commit intomoby:masterfrom
Closed
Conversation
Member
Author
7 tasks
Member
Author
|
CI failure seems unrelated #1643 |
AkihiroSuda
force-pushed
the
add-introspection-mount
branch
from
a1ecdae to
6e15c6e
Compare
Collaborator
|
@AkihiroSuda: If you rebase, CI should pass. ping @stevvooe for protobuf review |
Contributor
|
We need to decide whether the current INTROSPECTION api is what we want in docker before merging this. Relevant conversation in moby/moby#26331. Other than that, this looks like the right structure. I would add a comment that introspection doesn't have any options. |
Codecov Report@@ Coverage Diff @@
## master #1642 +/- ##
==========================================
+ Coverage 53.62% 55.15% +1.53%
==========================================
Files 107 97 -10
Lines 18403 15481 -2922
==========================================
- Hits 9868 8539 -1329
+ Misses 7319 5811 -1508
+ Partials 1216 1131 -85Continue to review full report at Codecov.
|
AkihiroSuda
force-pushed
the
add-introspection-mount
branch
from
6e15c6e to
2a19823
Compare
Member
Author
|
Rebased and improved the comment |
Member
Author
|
Test failure seems unrelated |
AkihiroSuda
force-pushed
the
add-introspection-mount
branch
from
2a19823 to
3aa3156
Compare
This mount type will be used for implementing "introspection" mount that allows you to introspect the metadata about the container from the container itself, via a procfs-like filesystem. (moby/moby#26331) Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
add-introspection-mount
branch
from
3aa3156 to
99ee7b7
Compare
Member
Author
|
Closing until we fix the design in moby/moby#26331 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mount type will be used for implementing "introspection" mount that allows you to introspect the
metadata about the container from the container itself, via a procfs-like filesystem.
(moby/moby#26331)
Signed-off-by: Akihiro Suda [email protected]