Removing dependancy on remote IPAM driver#1130
Merged
aaronlehmann merged 2 commits intomoby:masterfrom Jul 6, 2016
Merged
Conversation
Contributor
Author
|
ping @mrjana |
Contributor
Author
|
This PR is part 2 of moby/libnetwork#1310 in order to solve moby/moby#23990 |
Contributor
|
LGTM |
Member
|
|
Collaborator
|
CI failure is unrelated; fixed by #1135. |
Signed-off-by: Madhu Venugopal <[email protected]>
Signed-off-by: Madhu Venugopal <[email protected]>
Collaborator
|
@mavenugo: Please rebase to fix the CI failure. |
Current coverage is 55.19%@@ master #1130 diff @@
==========================================
Files 77 77
Lines 11947 11953 +6
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 6583 6597 +14
+ Misses 4452 4445 -7
+ Partials 912 911 -1
|
Contributor
Author
|
@aaronlehmann done. |
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
swarmkit currently doesnt support remote network drivers (via plugins). But it was dependent on libnetwork's drvregistry which was loading remote IPAM driver by default. This causes moby/moby#23990
The fix is to remove such built-in dependencies in drvregistry and move it to the caller similar to remote network driver.