Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: moby/spdystream
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.5.0
Choose a base ref
...
head repository: moby/spdystream
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.5.1
Choose a head ref
  • 20 commits
  • 14 files changed
  • 5 contributors

Commits on Mar 15, 2026

  1. update ltag module name 

    The repository was moved to the containerd org; also fix some minor
issues in the script to make it valid for POSIX shell.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Mar 15, 2026
    Configuration menu
    Copy the full SHA
    9c96114 View commit details
    Browse the repository at this point in the history

  2. spdy: fix duplicate license headers 

    The Apache 2 headers were added in 0c4d6b8,
which overlooked that these files were forked from the Go project, and
BSD licensed.

- Remove the Apache 2 headers
- Update the validate script to ignore the spdy directory

Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Mar 15, 2026
    Configuration menu
    Copy the full SHA
    750faf4 View commit details
    Browse the repository at this point in the history

  3. update NOTICE, add LICENSE and PATENTS in spdy directory 

    Code in the spdy directory was derived from the Go project (golang.org/x/net)
in commmit 866205e, because the code was removed
in upstream in golang/net@ff8eb9a

This patch:

- Adds the correct license and patents files to the directory.
- Adds a mention to the NOTICE file at the root of the repository.

Co-authored-by: Bob Badour <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah @bbadour
    thaJeztah and bbadour committed Mar 15, 2026
    Configuration menu
    Copy the full SHA
    4160b6e View commit details
    Browse the repository at this point in the history

  4. Merge pull request #106 from thaJeztah/fix_license_headers 

    spdy: fix duplicate license headers, add LICENSE, PATENTS, and update NOTICE
    @thaJeztah
    thaJeztah authored Mar 15, 2026
    Configuration menu
    Copy the full SHA
    6f72e20 View commit details
    Browse the repository at this point in the history

  5. ci: gha: format ci.yaml 

    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Mar 15, 2026
    Configuration menu
    Copy the full SHA
    eae6b3b View commit details
    Browse the repository at this point in the history

  6. ci: update workflow config 

    - set default permissions to 'content: read'
- limit concurrency
- set GOTOOLCHAIN: local to make sure the expected version of
  Go is used (prevent implicit upgrading)

Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Mar 15, 2026
    Configuration menu
    Copy the full SHA
    e060b91 View commit details
    Browse the repository at this point in the history

  7. ci: update to actions/setup-go@v6, actions/checkout@v6 

    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Mar 15, 2026
    Configuration menu
    Copy the full SHA
    d5a31fa View commit details
    Browse the repository at this point in the history

  8. ci: test on go1.13.x, oldstable, stable 

    Test the oldest version supported by the module, and currently
supported versions.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Mar 15, 2026
    Configuration menu
    Copy the full SHA
    c5a3b65 View commit details
    Browse the repository at this point in the history

  9. ci: test with -race 

    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Mar 15, 2026
    Configuration menu
    Copy the full SHA
    206d755 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2026

  1. Merge pull request #107 from thaJeztah/update_actions 

    ci: update actions and test against latest Go versions
    @thaJeztah
    thaJeztah authored Mar 16, 2026
    Configuration menu
    Copy the full SHA
    f0be51f View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2026

  1. Guard against oversized SPDY frames 

    Signed-off-by: Davanum Srinivas <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @dims @thaJeztah
    dims authored and thaJeztah committed Mar 29, 2026
    Configuration menu
    Copy the full SHA
    cf0ec5d View commit details
    Browse the repository at this point in the history

  2. spdy: enforce 24-bit frame length limits 

    SPDY control and data frame headers carry a 24-bit Length field, so
frame payloads must be limited to 2^24-1 bytes.

Tighten the write-side bounds checks accordingly. SETTINGS still encodes
its entry count as a 32-bit field, but the total payload must fit within
the 24-bit frame length.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Mar 29, 2026
    Configuration menu
    Copy the full SHA
    5976b66 View commit details
    Browse the repository at this point in the history

  3. spdy: fix header block byte accounting 

    writeHeaderValueBlock accounts for serialized 32-bit length/count fields
as 2 bytes, but they occupy 4 bytes on the wire.

Adjust the returned byte count to match the encoded header block layout.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Mar 29, 2026
    Configuration menu
    Copy the full SHA
    2f21da4 View commit details
    Browse the repository at this point in the history

  4. spdy: limit header-size and header-count 

    Signed-off-by: Davanum Srinivas <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @dims @thaJeztah
    dims authored and thaJeztah committed Mar 29, 2026
    Configuration menu
    Copy the full SHA
    eb63605 View commit details
    Browse the repository at this point in the history

  5. spdy: update godoc for MaxDataLength 

    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Mar 29, 2026
    Configuration menu
    Copy the full SHA
    acf9b45 View commit details
    Browse the repository at this point in the history

  6. Add options to customize limits 

    Guard against oversized SPDY frames

Signed-off-by: Davanum Srinivas <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @dims @thaJeztah
    dims authored and thaJeztah committed Mar 29, 2026
    Configuration menu
    Copy the full SHA
    21c3864 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2026

  1. compare with signed Int for 32-bit Arm 

    Signed-off-by: Samuel Karp <[email protected]>
    @samuelkarp
    samuelkarp committed Apr 13, 2026
    Configuration menu
    Copy the full SHA
    241cec9 View commit details
    Browse the repository at this point in the history

  2. Merge commit from fork 

    uint32
    @thaJeztah
    thaJeztah authored Apr 13, 2026
    Configuration menu
    Copy the full SHA
    ef6121f View commit details
    Browse the repository at this point in the history

  3. use ioutil.Discard for go1.13 compatibility 

    Signed-off-by: Sebastiaan van Stijn <[email protected]>
    @thaJeztah
    thaJeztah committed Apr 13, 2026
    Configuration menu
    Copy the full SHA
    2fd0155 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #109 from thaJeztah/use_ioutil 

    use ioutil.Discard for go1.13 compatibility
    @samuelkarp
    samuelkarp authored Apr 13, 2026
    Configuration menu
    Copy the full SHA
    c59e5d7 View commit details
    Browse the repository at this point in the history
Loading