update sigstore-go to b5fe07a5a#12
Merged
tonistiigi merged 1 commit intomoby:mainfrom Dec 2, 2025
Merged
Conversation
Removes the need for replace rules from forks. Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
commented
Nov 25, 2025
| module github.com/moby/policy-helpers | ||
|
|
||
| go 1.24.3 | ||
| go 1.25.0 |
Member
Author
There was a problem hiding this comment.
iiuc this is coming from https://github.com/letsencrypt/boulder/pull/8364/files#r2286329998 , while we don't even import boulder in any code path 🤦
cc @thaJeztah
Member
There was a problem hiding this comment.
Sigh... perhaps we should ask them why they're forcing go1.25; looks like it was just to reduce their CI matrix for no clear reason.
while we don't even import boulder in any code path 🤦
Yeah; go modules doesn't care if you use it or not; if a dependency is listed anywhere, it's used as part of version resolution;
go mod graph | grep 'github.com/letsencrypt/boulder'
github.com/sigstore/[email protected] github.com/letsencrypt/[email protected]
github.com/sigstore/rekor-tiles/[email protected] github.com/letsencrypt/[email protected]
github.com/sigstore/[email protected] github.com/letsencrypt/[email protected]
github.com/sigstore/[email protected] github.com/letsencrypt/[email protected]
github.com/sigstore/timestamp-authority/[email protected] github.com/letsencrypt/[email protected]
github.com/theupdateframework/go-tuf/[email protected] github.com/letsencrypt/[email protected]
I tried to convince the Go maintainers to prune before resolving, but that was rejected;
Member
Author
There was a problem hiding this comment.
crazy-max
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the need for replace rules from forks.
ref sigstore/sigstore-go#543