Move the daemon/graphdriver package to storage #9758
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though we refer to them commonly as "storage drivers" and they are used by more subsystems than just the daemon package - the container, image, and volume storage library is buried under the daemon package and is called `graphdriver` which is a very generic name. Also, some types it exposes like `graphdriver.Driver` is a stutter and is not idiomatic Go. This change moves the `daemon/graphdriver` package to the top-level of the `github.com/docker/docker` package tree under the name `storage`. Users of this package now deal with `storage.Driver` objects! And other subsystems which use it, like the `graph` package (another unfortunate name), have one fewer thing they have to reach into the `daemon` package for. All references to `graphdriver` (with the exception of environment variables and Go build tags) have been updated to use the new package location. Docker-DCO-1.1-Signed-off-by: Josh Hawn <[email protected]> (github: jlhawn)
Contributor
Author
|
@shykes @jfrazelle @LK4D4 @crosbymichael @erikh @vieux @icecrime @tianon @unclejack If you think this is a good idea, I would also like to propose moving a couple of other packages as well:
|
Contributor
|
Oh, I'm +100 for graph :) |
Contributor
Contributor
Author
|
oh! and @tiborvass ^ |
Contributor
Author
|
hey so I looked back in the history and it turns out that |
Contributor
Author
|
|
Contributor
Author
|
and even before that |
Contributor
Contributor
Author
|
sure 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though we refer to them commonly as "storage drivers" and they are used
by more subsystems than just the daemon package - the container, image, and
volume storage library is buried under the daemon package and is called
graphdriverwhich is a very generic name. Also, some types it exposes likegraphdriver.Driveris a stutter and is not idiomatic Go.This change moves the
daemon/graphdriverpackage to the top-level of thegithub.com/docker/dockerpackage tree under the namestorage. Users of thispackage now deal with
storage.Driverobjects! And other subsystems which useit, like the
graphpackage (another unfortunate name), have one fewer thingthey have to reach into the
daemonpackage for.All references to
graphdriver(with the exception of environment variablesand Go build tags) have been updated to use the new package location.