Skip to content

Comments

Merge release v1.3.2 to master#9323

Merged
tiborvass merged 13 commits intomoby:masterfrom
unclejack:merge_release_v1.3.2
Nov 25, 2014
Merged

Merge release v1.3.2 to master#9323
tiborvass merged 13 commits intomoby:masterfrom
unclejack:merge_release_v1.3.2

Conversation

@unclejack
Copy link
Contributor

No description provided.

unclejack and others added 11 commits November 25, 2014 00:27
Docker-DCO-1.1-Signed-off-by: Cristian Staretu <[email protected]> (github: unclejack)
These settings need to be in the HostConfig so that they are not
committed to an image and cannot introduce a security issue.

We can safely move this field from the Config to the HostConfig
without any regressions because these settings are consumed at container
created and used to populate fields on the Container struct.  Because of
this, existing settings will be honored for containers already created
on a daemon with custom security settings and prevent values being
consumed via an Image.

Signed-off-by: Michael Crosby <[email protected]>

Conflicts:
	daemon/create.go
		changing config to hostConfig was required to fix the
		 build
Docker-DCO-1.1-Signed-off-by: Cristian Staretu <[email protected]> (github: unclejack)

Conflicts:
	builder/internals.go
	daemon/graphdriver/aufs/aufs.go
	daemon/volumes.go
		fixed conflicts in imports
Signed-off-by: Tibor Vass <[email protected]>

Conflicts:
	graph/load.go
		fixed conflict in imports
Docker-DCO-1.1-Signed-off-by: Cristian Staretu <[email protected]> (github: unclejack)

Conflicts:
	daemon/graphdriver/aufs/aufs_test.go
		fixed conflict caused by imports
Signed-off-by: Tibor Vass <[email protected]>

Conflicts:
	pkg/archive/archive.go
		fixed conflict which git couldn't fix with the added BreakoutError

Conflicts:
	pkg/archive/archive_test.go
		fixed conflict in imports
Docker-DCO-1.1-Signed-off-by: Cristian Staretu <[email protected]> (github: unclejack)
@unclejack unclejack force-pushed the merge_release_v1.3.2 branch from 6ca7756 to 6cba358 Compare November 24, 2014 23:57
@crosbymichael
Copy link
Contributor

@unclejack looks like there are a few compile errors integrating this.

@unclejack unclejack force-pushed the merge_release_v1.3.2 branch from 6cba358 to 58c665c Compare November 25, 2014 00:04
unclejack and others added 2 commits November 25, 2014 02:06
Signed-off-by: Tibor Vass <[email protected]>
Signed-off-by: Cristian Staretu <[email protected]>
@unclejack unclejack force-pushed the merge_release_v1.3.2 branch from 58c665c to b21e1d4 Compare November 25, 2014 00:07
@unclejack
Copy link
Contributor Author

@crosbymichael @tiborvass Sorry for the delay. PTAL

@crosbymichael
Copy link
Contributor

LGTM

1 similar comment
@tiborvass
Copy link
Contributor

LGTM

tiborvass added a commit that referenced this pull request Nov 25, 2014
@tiborvass tiborvass merged commit e6ec703 into moby:master Nov 25, 2014
@unclejack unclejack deleted the merge_release_v1.3.2 branch November 25, 2014 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants