Fixes moby#8909

Signed-off-by: Alexandr Morozov <[email protected]>

Conflicts:
	integration-cli/docker_cli_ps_test.go
		fixed merge issue caused by missing tests

The doc (or src) says: The result is Cleaned.

http://golang.org/pkg/path/filepath/#Join

Signed-off-by: shuai-z <[email protected]>

Docker-DCO-1.1-Signed-off-by: Cristian Staretu <[email protected]> (github: unclejack)

These settings need to be in the HostConfig so that they are not
committed to an image and cannot introduce a security issue.

We can safely move this field from the Config to the HostConfig
without any regressions because these settings are consumed at container
created and used to populate fields on the Container struct.  Because of
this, existing settings will be honored for containers already created
on a daemon with custom security settings and prevent values being
consumed via an Image.

Signed-off-by: Michael Crosby <[email protected]>

Signed-off-by: Michael Crosby <[email protected]>

Docker-DCO-1.1-Signed-off-by: Cristian Staretu <[email protected]> (github: unclejack)

Conflicts:
	integration/runtime_test.go
		fixed imports

The vfs storage driver currently shells out to the `cp` binary on the host
system to perform an 'archive' copy of the base image to a new directory.
The archive option preserves the modified time of the files which are created
but there was an issue where it was unable to preserve the modified time of
copied symbolic links on some host systems with an outdated version of `cp`.

This change no longer relies on the host system implementation and instead
utilizes the `CopyWithTar` function found in `pkg/archive` which is used
to copy from source to destination directory using a Tar archive, which
should correctly preserve file attributes.

Docker-DCO-1.1-Signed-off-by: Josh Hawn <[email protected]> (github: jlhawn)

Docker-DCO-1.1-Signed-off-by: Cristian Staretu <[email protected]> (github: unclejack)

Docker-DCO-1.1-Signed-off-by: Cristian Staretu <[email protected]> (github: unclejack)

Signed-off-by: Tibor Vass <[email protected]>

Docker-DCO-1.1-Signed-off-by: Cristian Staretu <[email protected]> (github: unclejack)

Running parseVolumesFromSpec on all VolumesFrom specs before initialize
any mounts endures that we don't leave container.Volumes in an
inconsistent (partially initialized) if one of out mount groups is not
available (e.g. the container we're trying to mount from does not
exist).

Keeping container.Volumes in a consistent state ensures that next time
we Start() the container, it'll run prepareVolumes() again.

The attached test demonstrates that when a container fails to start due
to a missing container specified in VolumesFrom, it "remembers" a Volume
that worked.

Fixes: moby#8726

Signed-off-by: Thomas Orozco <[email protected]>

Conflicts:
	integration-cli/docker_cli_start_test.go
		cli integration test

Signed-off-by: Tibor Vass <[email protected]>

Conflicts:
	pkg/archive/archive.go
		fixed conflict which git couldn't fix with the added BreakoutError

Signed-off-by: Tibor Vass <[email protected]>

Signed-off-by: Tibor Vass <[email protected]>

Signed-off-by: Tibor Vass <[email protected]>

Conflicts:
	registry/endpoint.go
	registry/endpoint_test.go
	registry/registry_test.go

Signed-off-by: Tibor Vass <[email protected]>

Conflicts:
	registry/registry_mock_test.go

…ecure

Signed-off-by: Tibor Vass <[email protected]>

Signed-off-by: Tibor Vass <[email protected]>

Conflicts:
	registry/endpoint.go

Signed-off-by: Tibor Vass <[email protected]>

Conflicts:
	docs/sources/reference/commandline/cli.md

…ided

Since V2 registry does not yet implement mirrors, when mirrors are given automatically fallback to V1 without checking V2 first.

Signed-off-by: Derek McGowan <[email protected]> (github: dmcgowan)

Docker-DCO-1.1-Signed-off-by: Cristian Staretu <[email protected]> (github: unclejack)

Signed-off-by: Tibor Vass <[email protected]>

Signed-off-by: Tibor Vass <[email protected]>

Signed-off-by: Tibor Vass <[email protected]>