Corrected description of --sig-proxy #9144
Conversation
Signal proxy does work only in non-TTY mode (--tty=false). Man pages and commands should not lie about it. Signed-off-by: Michal Minar <[email protected]>
|
Doc fix is okay, but not addressing the problem smells ripe for more and more and more documentation needed for all the other corner-cases we simply haven't run into yet 😖 I'm a fan of applying #7567 instead. |
|
Docs LGTM |
|
LGTM |
|
LGTM, though doesn't the zsh tab completion have the flag text too? |
|
@miminar can you update the PR to also change the |
|
Docs LGTM once the change is propagated throughout as per @SvenDowideit FWIW, I agree it would be better to fix the issue, but we always have to document reality, even if we don't like it! |
Yes for sure, the more docs the better (underlying fix or not) 😄 |
|
@miminar ping? |
Signed-off-by: Michal Minar <[email protected]>
|
@SvenDowideit: Done. |
|
awesome, as they're really obvious identical changes, I'm going to treat everyone's review as done. So I'm mergeing, thankyou very much @miminar |
Corrected description of --sig-proxy
7 participants
Fixes: #5547
This PR just changes description of --sig-proxy which does work only in
non-TTY mode (--tty=false).
It obsoletes #7567 which I find superior to this because it fixes the
issue correctly.