Initialize volumes when container is created#9089
Conversation
cpuguy83
force-pushed
the
8942_create_volumes_on_create
branch
from
6827c3b to
ea71835
Compare
There was a problem hiding this comment.
Why do you have to mount?
There was a problem hiding this comment.
Presumably because we it is copying stuff from the container fs.
|
but you may need to add some more info (do we talk about volume creation and lifecycles yet, because we should :) so this means we can change our volume container docs to show you can
? |
There was a problem hiding this comment.
Unless you're referring to code directly (create?), this should probably be: Volumes are now initialized when created.
There was a problem hiding this comment.
Volumes are now initialized when created.
Perhaps better; "Volumes are now initialized when the container is created."?
(But the original could work too, to indicate that the create command is involved here)
There was a problem hiding this comment.
That's kind of my point. If we're referring to the command, we should be explicit: Building the container with create will now initialize the volume.
If not, @thaJeztah's revision is probably better than mine.
cpuguy83
force-pushed
the
8942_create_volumes_on_create
branch
from
ea71835 to
88c497e
Compare
|
@fredlf Updated |
There was a problem hiding this comment.
There's a stray "on"; 'initialized on when' should be 'initialized when'
Fixes moby#8942 Current behavior is that volumes aren't initialized until start. Volumes still need to be initialized on start since VolumesFrom and Binds can be passed in as part of HostConfig on start, however anything that's already been initialized will just be skipped as is the current behavior. Signed-off-by: Brian Goff <[email protected]>
cpuguy83
force-pushed
the
8942_create_volumes_on_create
branch
from
88c497e to
7107898
Compare
|
LGTM |
|
ping @jfrazelle ;) |
|
LGTM |
Initialize volumes when container is created
|
cherry-picked for 1.4.0 |
7 participants
Fixes #8942
Current behavior is that volumes aren't initialized until start.
Volumes still need to be initialized on start since VolumesFrom and
Binds can be passed in as part of HostConfig on start, however anything
that's already been initialized will just be skipped as is the current
behavior.