docker commit --change support#8765
Conversation
Docker-DCO-1.1-Signed-off-by: Daniel, Dao Quang Minh <[email protected]> (github: dqminh)
Instead of building the actual image, `build_config` will serialize a subset of dockerfile ast into *runconfig.Config Docker-DCO-1.1-Signed-off-by: Daniel, Dao Quang Minh <[email protected]> (github: dqminh)
In addition to config env, `commit` now will also accepts a `changes` env which is a string contains new-line separated Dockerfile instructions. `commit` will evaluate `changes` into `runconfig.Config` and merge it with `config` env, and then finally commit a new image with the changed config Docker-DCO-1.1-Signed-off-by: Daniel, Dao Quang Minh <[email protected]> (github: dqminh)
Docker-DCO-1.1-Signed-off-by: Daniel, Dao Quang Minh <[email protected]> (github: dqminh)
Signed-off-by: Michael Crosby <[email protected]>
There was a problem hiding this comment.
we should probably do all of this below in the dispatcher. not here.
There was a problem hiding this comment.
Why are we instantiating the parser and evaluator here in a way which is extremely similar but subtly different, and prone to bit rot later? There has to be a better solution than this.
There was a problem hiding this comment.
Well let us know what you want done as you are most familiar with the builder code.
|
Before this gets merged we need to have the exact same functionality for docker import. Is someone going to work on this, or should I start playing with it? |
|
|
yes ;) i can send a docs PR to @crosbymichael branch later today. I guess that beside some code changes that need to be made, the cli's UI change should be good ( cc @shykes ) |
|
Glad to see this one moving forward. |
Docker-DCO-1.1-Signed-off-by: Daniel, Dao Quang Minh <[email protected]> (github: dqminh)
|
@SvenDowideit i sent a pull request to @crosbymichael fork with the docs change crosbymichael#30. PTAL |
add docs for commit --change
|
Docs LGTM |
|
@rhatdan I think the |
|
Docs LGTM. Okay for merge from docs' POV. |
|
Closing in favor of #9123 |
10 participants
Replaces #8332 fixing an issue with returning a hard error when there is an invalid command for commit.