Skip to content

Comments

Make fixed font sizes smaller per Issue #5278#8343

Merged
fredlf merged 1 commit intomoby:masterfrom
duglin:Issue5278
Oct 6, 2014
Merged

Make fixed font sizes smaller per Issue #5278#8343
fredlf merged 1 commit intomoby:masterfrom
duglin:Issue5278

Conversation

@duglin
Copy link
Contributor

@duglin duglin commented Oct 1, 2014

Closes #5278

Signed-off-by: Doug Davis [email protected]

@jessfraz
Copy link
Contributor

jessfraz commented Oct 1, 2014

nice css :) unsure who to ping on this @SvenDowideit ?

@jamtur01
Copy link
Contributor

jamtur01 commented Oct 1, 2014

LGTM Ping @fredlf @rogaha

@fredlf
Copy link
Contributor

fredlf commented Oct 1, 2014

I assume this has been tested and you've looked at various pages to make sure there are no unintended consequences (because, CSS). Ping @ChristopherBiscardi also.

@duglin
Copy link
Contributor Author

duglin commented Oct 2, 2014

I tried my best to look for any impact but a you said, its tricky.

@fredlf
Copy link
Contributor

fredlf commented Oct 2, 2014

@duglin Appreciate the effort and feel your pain! LGTM, but I would really like our front-end guy, @ChristopherBiscardi to take a look and weigh in before we merge.

@ChristopherBiscardi
Copy link
Contributor

@fredlf If this looks good to you re: font-size, then LGTM pending line-height comments below.

screenshot 2014-10-06 06 24 42

We should floor the line-height at 1.5 minimum here. Anything less and the quotes start to become part of the previous lines making it awkward to read (screenshot is at 1.2). If the example responses are too long we should start thinking about different ways to display them.

I'm happy to see the universal selector go (*) and we already have a style for .content-body p which should cover our bases since we're converting from markdown.

@duglin
Copy link
Contributor Author

duglin commented Oct 6, 2014

bumped the line-height change from 1.2 to 1.5 per @ChristopherBiscardi 's comment

@ChristopherBiscardi
Copy link
Contributor

+1

@fredlf
Copy link
Contributor

fredlf commented Oct 6, 2014

Thanks @ChristopherBiscardi , and thanks for the contribution @duglin .

fredlf pushed a commit that referenced this pull request Oct 6, 2014
Make fixed font sizes smaller per Issue #5278
@fredlf fredlf merged commit 3fc04f3 into moby:master Oct 6, 2014
@duglin duglin deleted the Issue5278 branch October 6, 2014 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remote API doc formatting comments

5 participants