Add support for 'docker exec' - phase 2#8062
Merged
LK4D4 merged 12 commits intomoby:masterfrom Sep 16, 2014
Merged
Conversation
Modified Attach() method to support docker exec. Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <[email protected]> (github: vishh)
Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <[email protected]> (github: vishh)
Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <[email protected]> (github: vishh)
Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <[email protected]> (github: vishh)
…' feature. Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <[email protected]> (github: vishh)
Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <[email protected]> (github: vishh)
Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <[email protected]> (github: vishh)
Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <[email protected]> (github: vishh)
… resizing of tty sessions for exec'ed commands. Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <[email protected]> (github: vishh)
…rt resizing of tty sessions. 1. /container/<name>/exec - Creates a new exec command instance in the daemon and container '<name>'. Returns an unique ID for each exec command. 2. /exec/<name>/start - Starts an existing exec command instance. Removes the exec command from the daemon once it completes. Adding /exec/<name>/resize to resize tty session of an exec command. Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <[email protected]> (github: vishh)
…exec command. Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <[email protected]> (github: vishh)
Contributor
Author
|
Ping @crosbymichael, @vieux, @tianon |
vishh
force-pushed
the
run_in_phase2
branch
from
f6ed3f7 to
b3d1114
Compare
Contributor
Author
|
Ping @fredlf @SvenDowideit for docs/* |
Contributor
|
nice!!! trying it out now! |
Contributor
|
resize works well 👍 |
Contributor
There was a problem hiding this comment.
I am not the biggest fan of this, but also can't think of a more elegant way..
Contributor
Author
There was a problem hiding this comment.
I tried to avoid unnecessary code duplication.
vishh
force-pushed
the
run_in_phase2
branch
from
b3d1114 to
46284e1
Compare
Contributor
|
Docs were approved for this in the previous PR, no additional review is needed there |
Contributor
|
LGTM |
vishh
force-pushed
the
run_in_phase2
branch
from
46284e1 to
596f2b9
Compare
Contributor
|
LGTM |
Contributor
|
Tested with different user privileges and caps, with different tty/stdin flags: all good. Did not review code. |
Contributor
Why two |
Contributor
There was a problem hiding this comment.
per @LK4D4's comment you need to remove [OPTIONS] here it gets added automatically.
Fixed a bug in daemon that resulted in accessing of a closed pipe. Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <[email protected]> (github: vishh)
vishh
force-pushed
the
run_in_phase2
branch
from
596f2b9 to
c786a8e
Compare
Contributor
Author
|
@LK4D4: Good catch. Fixed it. |
Contributor
|
LGTM |
LK4D4
added a commit
that referenced
this pull request
Sep 16, 2014
Add support for 'docker exec' - phase 2
This was referenced Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7409
Fixes #6777
Fixes #1228
Daemon now supports resizing of tty sessions used for exec.
'exec' Remote API introduced in #7409 has been split into '/containers//exec' and '/exec//start'.
'/exec//resize' has been added to support resizing of exec tty sessions.