Fix line delimited JSON response#7886
Conversation
|
@paultag can you please take a look? Thanks. |
|
all over checking this out tonight. sweeettttttttttttttttttttttttttttt On Thu, Sep 4, 2014 at 3:08 PM, Victor Vieux [email protected]
:wq |
|
Is there a way we can add a Test case for this? |
|
ya I was thinking of a way to go about that |
jessfraz
force-pushed
the
7047-json-line-delim
branch
3 times, most recently
from
385cb44 to
80fb36a
Compare
There was a problem hiding this comment.
I'm not sure that cli tests is place for doing such things. We definitely need api tests, but we have no still :) This possibly could be tested in events unit_tests by creating fake job and adding connecting pipe to stdout.
There was a problem hiding this comment.
But maybe it's time to bring api testing. ping @unclejack
There was a problem hiding this comment.
I'm OK with doing this. The name integration-cli still applies, the tests can do what it takes to get changes tested.
jessfraz
force-pushed
the
7047-json-line-delim
branch
2 times, most recently
from
b77c629 to
61ad09f
Compare
|
ping @LK4D4 moved test to a docker_api_events_test.go file |
|
also ping @unclejack @tiborvass |
There was a problem hiding this comment.
I'm not sure about this code. You can only test that answer is EOL-delimited by this :) It should be in your test I think. Here I think should be only:
ioutil.ReadAll(resp.Body)
61ad09f to
2bbbc20
Compare
There was a problem hiding this comment.
I think you do need to do a defer client.Close().
There was a problem hiding this comment.
right my b, got a little delete happy
|
updated ping @LK4D4 @tiborvass |
jessfraz
force-pushed
the
7047-json-line-delim
branch
from
2bbbc20 to
c7539d4
Compare
There was a problem hiding this comment.
You could add linesRead for more information.
jessfraz
force-pushed
the
7047-json-line-delim
branch
from
c7539d4 to
4e56094
Compare
|
LGTM |
|
please rebase |
For GET /events, line delimit JSON. Fixes moby#7047 Signed-off-by: Jessica Frazelle <[email protected]> Docker-DCO-1.1-Signed-off-by: Jessica Frazelle <[email protected]> (github: )
jessfraz
force-pushed
the
7047-json-line-delim
branch
from
4e56094 to
d2f75a3
Compare
|
rebased :) |
|
LGTM |
|
Thanks @jfrazelle |
6 participants
For GET /events, line delimit JSON.
Fixes #7047
Signed-off-by: Jessica Frazelle [email protected]