make docker pull only the latest tag by default by unclejack · Pull Request #7759 · moby/moby

unclejack · 2014-08-27T12:43:09Z

This PR changes docker pull to add a flag called --all-tags (-a for the short version) to make Docker pull only the latest tag of a repository by default.

These changes are limited to the Docker CLI. The API and the daemon aren't modified for this change.

This will help speed up pulls. This PR is also removing the --tag flag because it doesn't make sense to keep it around any more.

The docs have been added, thanks to @SvenDowideit.

unclejack · 2014-08-27T12:43:21Z

ping @dmp42

LK4D4 · 2014-08-27T16:48:55Z

LGTM

dmp42 · 2014-08-27T18:28:41Z

LGTM

dmp42 · 2014-08-27T18:29:06Z

@unclejack can you rebase?

vieux · 2014-08-27T18:30:29Z

api/client/commands.go

why do we always set the tag to "" ?

It seems unused.

yes, so why not remove this line ?

@vieux I was under the impression it's still needed in the API. I'll remove it.

SvenDowideit · 2014-08-27T23:29:12Z

yup :) needs Docs

SvenDowideit · 2014-08-29T00:18:21Z

@unclejack I've made you unclejack#5

I guess we need something in the API too?

unclejack · 2014-08-29T13:31:04Z

@SvenDowideit Thank you! I've merged the docs changes you've made into this branch.
We don't have to change anything in the API, the changes were made only on the client.

Those who use the API can already choose to append :latest to pull only the latest image, so I don't think we have to make any change there.

unclejack · 2014-08-29T14:40:46Z

@crosbymichael @tiborvass @vieux This PR is ready for code review.

@fredlf @jamtur01 Can you take a look at this PR, please? Thanks to @SvenDowideit, it now has docs.

fredlf · 2014-08-29T17:44:49Z

docs/sources/reference/commandline/cli.md

I think we should omit this line. It belongs in release notes, not reference, IMHO. It won't be relevant after a couple of releases.

fredlf · 2014-08-29T17:45:24Z

Docs LGTM if we omit the line I commented on.

tianon · 2014-08-29T19:50:23Z

I've gotta say, I really dislike this change a lot, but I understand the
justification (consistent experience etc).

unclejack · 2014-08-29T21:56:37Z

@tianon Could you explain why you dislike the change, please? Most users really want to use the latest tag or don't care much about this and they end up using bandwidth.

tianon · 2014-08-29T23:24:40Z

Well, right now, when I "docker pull xyz", it's completely unambiguous what
I mean. I'm asking Docker to pull a "repository", which is a collection of
tags, so I logically understand that to mean that it pulls all tags. If I
only wanted one, I should've done "docker pull xyz:abc" instead. I'd love
to see us deprecate ":latest" tags entirely, to be honest, but they're a
nice abstraction during "docker run" so you can have pretty things like
"docker run -it ubuntu bash" and it actually does something useful (which
is why I support this particular "bare repo means :latest" behavior for
"docker run").

wyaeld · 2014-09-02T02:39:31Z

As a user I'm +1 on this. It seems a safer default.

I think people quickly get to the point where they understand the distinction @tianon is talking about, but I'd disagree that the interpretation that the normal users intent is to have the entire collection of tags.

Sometimes you just get unpleasantly surprised by how big something is, or how many tags they have. For the new users, seeing a huge amount of stuff coming down the pipe when they just want to get started is a turnoff. It isn't helped by the fact that if the ctrl+c it, the client doesn't always gracefully reset.

dmp42 · 2014-09-02T15:57:03Z

docs/sources/reference/commandline/cli.md

Shouldn't that read --all-tags instead of --all-images?

@dmp42 You're right, I'll change this with the next update. I need to add some changes for docker builld.

tianon · 2014-09-02T19:11:45Z

Just out of curiosity, do we get a good error message if we do something
like "docker pull --all-tags debian:wheezy" ?

Docker-DCO-1.1-Signed-off-by: Cristian Staretu <[email protected]> (github: unclejack)

Docker-DCO-1.1-Signed-off-by: SvenDowideit <[email protected]> (github: SvenDowideit)

Docker-DCO-1.1-Signed-off-by: Cristian Staretu <[email protected]> (github: unclejack)

unclejack · 2014-09-03T15:35:29Z

@tianon Yes, you'll get an error saying tag can't be used with --all-tags/-a.

I've updated the PR to make docker build only pull the latest tag. This change also didn't require any API changes. The latest tag was always used for building if no tag was specified, so it makes sense to pull only the latest tag for a build.

I don't think the docker build change requires any changes to the docs. Please let me know if you think we should add docs somewhere.

@fredlf I've removed that line.
@fredlf @SvenDowideit Please take a look at the docs and let me know if you'd like to make any changes. I've updated the line with --all-images and the line below it.

@crosbymichael @jfrazelle @LK4D4 @tiborvass @vieux This should be ready for review. Please let me know if there's anything you'd like to change.

tianon · 2014-09-03T16:03:41Z

Thanks for clarifying, unclejack. :)

I'm +1 on consistency, and I'll get used to the new interface. :)

dmp42 · 2014-09-03T16:57:10Z

LGTM

thaJeztah · 2014-09-03T21:03:05Z

The latest tag was always used for building if no tag was specified, so it makes sense to pull only the latest tag for a build.

👍 thanks unclejack !

fredlf · 2014-09-04T19:54:38Z

Docs LGTM

jamtur01 · 2014-09-04T19:56:12Z

Docs LGTM

shykes · 2014-09-08T17:46:59Z

Design LGTM

jessfraz · 2014-09-08T17:52:33Z

is it possible to add a test for this? or is it too complicated at this point to make sure the latest is always the latest, etc
or maybe pull ubuntu and ubuntu:latest and compare sha's

unclejack · 2014-09-08T17:55:52Z

@jfrazelle I think we can do this if we set up a mock registry to pull from it, but I think it's out of scope of this PR.

jessfraz · 2014-09-08T17:59:22Z

makes sense LGTM

On Mon, Sep 8, 2014 at 10:56 AM, unclejack [email protected] wrote:

@jfrazelle https://github.com/jfrazelle I think we can do this if we
set up a mock registry to pull from it, but I think it's out of scope of
this PR.

—
Reply to this email directly or view it on GitHub
#7759 (comment).

tiborvass · 2014-09-08T18:53:06Z

LGTM

crosbymichael · 2014-09-08T20:43:13Z

LGTM

make docker pull only the latest tag by default

This was changed in Docker recently: moby/moby#7759 This means we aren't pulling loads of tags when we only use the latest. Signed-off-by: Ben Firshman <[email protected]>

This was changed in Docker recently: moby/moby#7759 This means we aren't pulling loads of tags when we only use the latest. Signed-off-by: Ben Firshman <[email protected]> Signed-off-by: Yuval Kohavi <[email protected]>

unclejack force-pushed the pull_latest_by_default branch from 0db5b83 to cbbb1ab Compare August 27, 2014 12:51

vieux reviewed Aug 27, 2014
View reviewed changes

SvenDowideit added the /project/doc label Aug 27, 2014

unclejack force-pushed the pull_latest_by_default branch from 4c18872 to b7b8467 Compare August 29, 2014 14:38

fredlf reviewed Aug 29, 2014
View reviewed changes

dmp42 reviewed Sep 2, 2014
View reviewed changes

add --all-tags to pull & pull latest by default

9c08364

Docker-DCO-1.1-Signed-off-by: Cristian Staretu <[email protected]> (github: unclejack)

unclejack force-pushed the pull_latest_by_default branch 2 times, most recently from cc1ebfe to 6ba5d67 Compare September 3, 2014 15:32

SvenDowideit and others added 2 commits September 3, 2014 18:32

add a little documentation for docker pull

82b0c3e

Docker-DCO-1.1-Signed-off-by: SvenDowideit <[email protected]> (github: SvenDowideit)

docker build: pull just latest if tag uspecified

6ba5d67

Docker-DCO-1.1-Signed-off-by: Cristian Staretu <[email protected]> (github: unclejack)

thaJeztah mentioned this pull request Sep 3, 2014

Parity between FROM in Dockerfiles and Docker pull {Image} #6359

Closed

crosbymichael added a commit that referenced this pull request Sep 8, 2014

Merge pull request #7759 from unclejack/pull_latest_by_default

85314e7

make docker pull only the latest tag by default

crosbymichael merged commit 85314e7 into moby:master Sep 8, 2014

unclejack deleted the pull_latest_by_default branch September 8, 2014 23:51

bfirsh added a commit to bfirsh/fig that referenced this pull request Dec 9, 2014

Pull latest tag by default

c353ab1

This was changed in Docker recently: moby/moby#7759 This means we aren't pulling loads of tags when we only use the latest. Signed-off-by: Ben Firshman <[email protected]>

bfirsh mentioned this pull request Dec 9, 2014

Pull latest tag by default docker/compose#716

Merged

bfirsh added a commit to bfirsh/fig that referenced this pull request Dec 11, 2014

Pull latest tag by default

309c4b1

This was changed in Docker recently: moby/moby#7759 This means we aren't pulling loads of tags when we only use the latest. Signed-off-by: Ben Firshman <[email protected]>

bfirsh added a commit to bfirsh/fig that referenced this pull request Dec 11, 2014

Pull latest tag by default

f75d5c3

This was changed in Docker recently: moby/moby#7759 This means we aren't pulling loads of tags when we only use the latest. Signed-off-by: Ben Firshman <[email protected]>

bfirsh added a commit to bfirsh/fig that referenced this pull request Dec 11, 2014

Pull latest tag by default

8ebec9a

This was changed in Docker recently: moby/moby#7759 This means we aren't pulling loads of tags when we only use the latest. Signed-off-by: Ben Firshman <[email protected]>

tianon mentioned this pull request Dec 5, 2019

[proposal] change "docker push" behavior to default to ":latest" instead of "all tags" docker/cli#2214

Closed

3 tasks

thaJeztah mentioned this pull request Dec 10, 2019

client.ImagePush(): default to ":latest" instead of "all tags" #40302

Merged

Conversation

unclejack commented Aug 27, 2014

Uh oh!

unclejack commented Aug 27, 2014

Uh oh!

LK4D4 commented Aug 27, 2014

Uh oh!

dmp42 commented Aug 27, 2014

Uh oh!

dmp42 commented Aug 27, 2014

Uh oh!

vieux Aug 27, 2014

Choose a reason for hiding this comment

Uh oh!

unclejack Aug 28, 2014

Choose a reason for hiding this comment

Uh oh!

vieux Aug 28, 2014

Choose a reason for hiding this comment

Uh oh!

unclejack Aug 28, 2014

Choose a reason for hiding this comment

Uh oh!

SvenDowideit commented Aug 27, 2014

Uh oh!

SvenDowideit commented Aug 29, 2014

Uh oh!

unclejack commented Aug 29, 2014

Uh oh!

unclejack commented Aug 29, 2014

Uh oh!

fredlf Aug 29, 2014

Choose a reason for hiding this comment

Uh oh!

fredlf commented Aug 29, 2014

Uh oh!

tianon commented Aug 29, 2014

Uh oh!

unclejack commented Aug 29, 2014

Uh oh!

tianon commented Aug 29, 2014

Uh oh!

wyaeld commented Sep 2, 2014

Uh oh!

dmp42 Sep 2, 2014

Choose a reason for hiding this comment

Uh oh!

unclejack Sep 2, 2014

Choose a reason for hiding this comment

Uh oh!

tianon commented Sep 2, 2014

Uh oh!

unclejack commented Sep 3, 2014

Uh oh!

tianon commented Sep 3, 2014

Uh oh!

dmp42 commented Sep 3, 2014

Uh oh!

thaJeztah commented Sep 3, 2014

Uh oh!

fredlf commented Sep 4, 2014

Uh oh!

jamtur01 commented Sep 4, 2014

Uh oh!

shykes commented Sep 8, 2014

Uh oh!

jessfraz commented Sep 8, 2014

Uh oh!

unclejack commented Sep 8, 2014

Uh oh!

jessfraz commented Sep 8, 2014

Uh oh!

tiborvass commented Sep 8, 2014

Uh oh!

crosbymichael commented Sep 8, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects