Remove deprecated server package#7497
Conversation
shykes
commented
Aug 9, 2014
- Move "pull" to graph/pull.go
- Move "push" to graph/push.go
- Move "build" to daemon/build.go
- Remove the deprecated server package
- Simplify daemon creation: call NewDaemon() straight from main()
|
Ping @crosbymichael @tibor @LKD4D @unclejack Note: legacy Unit tests and CLI integration tests seem to pass well. |
|
Pretty much fails :) I'll take a look. |
|
I indeed, don't see why the MTU and network init configs should not be done inside NewDaemon. |
|
Thanks @tiborvass, that was it. For now I'm leaving a FIXME to cleanup how Ready for review. |
|
This depends no #7496. |
|
LGTM, but don't merge before #7496 |
|
Ping |
|
LGTM |
|
This has a commit (with a different commitid) from the PR #7496 that has already been merged. Not sure if it's a problem. |
|
@tiborvass it should be removed I think |
|
@shykes do you have time to rebase this PR? |
|
Yes will do this afternoon On Monday, August 11, 2014, Michael Crosby [email protected] wrote:
|
Signed-off-by: Solomon Hykes <[email protected]>
|
Rebased |
|
@shykes gofmt failed |
Victory! Signed-off-by: Solomon Hykes <[email protected]>
|
#@^%#*@&^@^$@ fixed |
|
LGTM |
|
LGTM |
Remove deprecated server package