Cleanup: move "pull" and "push" to graph/pull.go and graph/push.go#7496
Merged
shykes merged 1 commit intomoby:masterfrom Aug 11, 2014
Merged
Cleanup: move "pull" and "push" to graph/pull.go and graph/push.go#7496shykes merged 1 commit intomoby:masterfrom
shykes merged 1 commit intomoby:masterfrom
Conversation
This is part of the ongoing effort to remove the deprecated server/ package, and generally cleanup and simplify the codebase. Signed-off-by: Solomon Hykes <[email protected]>
Contributor
|
LGTM. Tests pass. Didn't see changes in the moved functions apart from removing |
Contributor
|
LGTM, I've also tested push and pull with hub and local registry. |
Contributor
|
LGTM |
Contributor
Author
|
Thanks for review guys. Merging. |
shykes
pushed a commit
that referenced
this pull request
Aug 11, 2014
Cleanup: move "pull" and "push" to graph/pull.go and graph/push.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of the ongoing effort to remove the deprecated
server/package, and generally cleanup and simplify the codebase.Signed-off-by: Solomon Hykes [email protected]