Make lxc driver rbind all user specified mounts.#7295
Merged
crosbymichael merged 2 commits intomoby:masterfrom Aug 1, 2014
Merged
Make lxc driver rbind all user specified mounts.#7295crosbymichael merged 2 commits intomoby:masterfrom
crosbymichael merged 2 commits intomoby:masterfrom
Conversation
Contributor
Author
|
Ping @dineshs-altiscale. |
Contributor
|
Can you guys write tests for this, so someone that creates a new driver knows they're getting it right, that we know it works the same way for libcontainer and lxc, and no-one breaks it in future without knowing that it matters? |
Contributor
Author
|
@SvenDowideit: Good suggestion. I went ahead and added an integration test. |
Contributor
|
@vishh the integration tests should go in |
Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <[email protected]> (github: vishh)
Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <[email protected]> (github: vishh)
Contributor
Author
|
@crosbymichael Done. PTAL |
Contributor
|
LGTM |
Contributor
|
ping @dineshs-altiscale please review |
Contributor
|
sorry guys -- LGTM |
crosbymichael
pushed a commit
that referenced
this pull request
Aug 1, 2014
Make lxc driver rbind all user specified mounts.
Contributor
|
nice! I'm starting to use the integration-cli tests to confirm how i think Docker works, so this help me a lot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required for running cadvisor with lxc driver.
Fixes #3782