Improve systemd units #7257
Merged
Improve systemd units #7257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
You need to sign every commit with the Docker DCO. |
See: https://bugs.archlinux.org/task/41338 Docker-DCO-1.1-Signed-off-by: Sébastien Luttringer <[email protected]> (github: seblu)
And remove the WantedBy directive. See: https://bugs.archlinux.org/task/41338 Docker-DCO-1.1-Signed-off-by: Sébastien Luttringer <[email protected]> (github: seblu)
Contributor
Author
|
done. |
Contributor
Contributor
|
a minor typo in the third commit message - 'servide', no biggie 😄 |
lsm5
referenced
this pull request
Jul 27, 2014
modified: contrib/init/systemd/docker.service Docker-DCO-1.1-Signed-off-by: Lokesh Mandvekar <[email protected]> (github: lsm5)
Contributor
|
lgtm |
This should not be done by default but used by adminsys with a drop-in.d file, for buggy daemons which crash without known fixes. Docker-DCO-1.1-Signed-off-by: Sébastien Luttringer <[email protected]> (github: seblu)
Contributor
Author
|
typo fixed. |
Member
|
Does this relate to #7254? My systemd-fu is admittedly weak. 😄 |
Contributor
Member
|
So this one includes the same fixes as that one and then some? Seems fine to me. 👍 You guys are the maintainers here there, so I'm going to take your two LGTM and merge. ;) |
liusdu
pushed a commit
to liusdu/moby
that referenced
this pull request
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This come from the following Archlinux bug report: https://bugs.archlinux.org/task/41338
Basically it fixe start ordering between service and socket file, also install socket when you install service, and, finally doesn't restart by default the service on failure. Doing that is reserver to buggy service, which is not the case of docker.