Adding custom bridge support to docker run by vishh · Pull Request #6704 · moby/moby

vishh · 2014-06-26T22:58:09Z

Docker will now accept a pre-existing bridge as an argument to docker run to create the networking stack on the user specified bridge instead of docker0.

Fixes issue #6155.

vishh · 2014-06-26T22:58:37Z

Ping @crosbymichael @vieux

vieux · 2014-06-26T23:09:26Z

docs/sources/reference/commandline/cli.md

I don't know in the generated docs, but the output looks weird (tabs/spaces)

vishh · 2014-06-27T19:20:07Z

Ping @vieux @crosbymichael

crosbymichael · 2014-06-27T21:22:43Z

It looks like your script picked up some vendor changes on the formatting

vendor/src/github.com/coreos/go-systemd/dbus has changes

vishh · 2014-06-27T21:49:22Z

Sorry about that.. Fixed.

crosbymichael · 2014-06-28T00:07:15Z

Do you think we should do anything around creating a bridge if it does not exist?

vishh · 2014-06-28T01:44:46Z

I want to eventually. We could something like --net "bridge:name:CIDR" which would instruct docker to create the bridge. I am not sure who needs that feature at this point though. WDYT?
Are you OK with this patch?

tianon · 2014-06-28T02:17:20Z

We talked about creation at the meeting and decided that it's easier to add
creation later than to take it away, especially since it makes the UI
slightly more complex.

SvenDowideit · 2014-06-30T05:18:08Z

needs an update of docs/man/docker-run.1.md too - sorry, I we need to write some code to share those.

vishh · 2014-06-30T06:08:56Z

@SvenDowideit Has docs/man/docker-run.1.md been updated recently? I don't see '--net' option mentioned at all.

vishh · 2014-06-30T17:33:49Z

@crosbymichael @vieux do you guys have any other comments?

vishh · 2014-07-01T17:52:02Z

Ping @vieux

vieux · 2014-07-02T19:06:04Z

Sorry @vishh, we will take a look soon, I moved this into the 1.1.1 milestone.

fkautz · 2014-07-08T00:19:29Z

@vishh Looks like there are some conflicts, can you rebase this?

SvenDowideit · 2014-07-08T01:43:56Z

@vishh yes, I see --net stuff at about line 176 in the man page - though I also see a bug in it :)

vishh · 2014-07-11T00:30:17Z

@SvenDowideit: I have updated docker-run.1.md.
@fkautz: Rebased
Ping @vieux @crosbymichael

Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <[email protected]> (github: vishh)

… docker run. Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <[email protected]> (github: vishh)

Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <[email protected]> (github: vishh)

vishh · 2014-07-16T16:52:17Z

Ping @vieux @crosbymichael

SvenDowideit · 2014-07-18T00:46:23Z

docs/sources/reference/run.md

Can you give an fully worked example for someone to follow in the networking.md article?

mind you Docs LGTM @jamtur01 @fredlf @ostezer

fredlf · 2014-07-18T17:42:34Z

LGTM once my/ostezer's comment is a addressed.

vishh · 2014-07-18T17:46:18Z

There is an ongoing discussion on #docker-dev about handling custom
networking setups. This PR might change significantly depending on the
outcome of that discussion.

On Fri Jul 18 2014 at 10:43:11 AM, Fred Lifton [email protected]
wrote:

LGTM once my/ostezer's comment is a addressed.

—
Reply to this email directly or view it on GitHub
#6704 (comment).

tristanz · 2014-08-12T19:29:33Z

Is there any resolution to this from #docker-dev discussion?

vishh · 2014-08-12T19:31:11Z

Ping @erikh. Are you working on a generic solution for netowkr related
plugins?

On Tue, Aug 12, 2014 at 12:30 PM, Tristan Zajonc [email protected]
wrote:

Is there any resolution to this from #docker-dev discussion?

—
Reply to this email directly or view it on GitHub
#6704 (comment).

erikh · 2014-08-12T19:35:40Z

That’s coming later.

On Aug 12, 2014, at 12:31 PM, Vish Kannan [email protected] wrote:

Ping @erikh. Are you working on a generic solution for netowkr related
plugins?

On Tue, Aug 12, 2014 at 12:30 PM, Tristan Zajonc [email protected]
wrote:

Is there any resolution to this from #docker-dev discussion?

—
Reply to this email directly or view it on GitHub
#6704 (comment).

—
Reply to this email directly or view it on GitHub #6704 (comment).

tristanz · 2014-08-12T19:37:26Z

Just to list our use case here: we would like containers to be assigned to specific subnets in AWS VPC environment. This pull request seems like a nice simple solution, in line with --net option, that shouldn't be too disruptive to future plans. So +1 for this feature unless there's a clear alternative in the works that I'm unaware of.

shykes · 2014-11-01T01:18:05Z

Hi @vishh, this PR is causing the same concerns as described in #7436 (comment) . Bottom line, we strongly agree with the need for this feature, but want to implement a different way, using hooks/plugins. There are a whole bunch of people interested in helping with this, so we'll probably put together some sort of hackfest to get it done. Sorry for closing this, I hope you'll join the fun :)

vieux reviewed Jun 26, 2014
View reviewed changes

vishh added the /project/doc label Jun 27, 2014

vishh mentioned this pull request Jun 27, 2014

Allow users to specify an IP for their container #6743

Closed

vieux added this to the 1.1.1 milestone Jul 2, 2014

fkautz added the /system/networking label Jul 8, 2014

vishh added 6 commits July 11, 2014 17:09

Adding custom bridge support to network driver.

3f4837d

Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <[email protected]> (github: vishh)

Adding custom bridge support in docker.

f7a4aae

Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <[email protected]> (github: vishh)

Custom bridge support added to container linking logic.

7a3a377

Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <[email protected]> (github: vishh)

Updating the docs to reflect the newly added custom bridge support in…

c8f413b

… docker run. Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <[email protected]> (github: vishh)

Fixing comments.

30e9d8b

Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <[email protected]> (github: vishh)

Updated docker-run.1.md with custom bridge option.

8433b4b

Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <[email protected]> (github: vishh)

vieux modified the milestones: 1.1.2, 1.1.1 Jul 11, 2014

bgrant0607 mentioned this pull request Jul 11, 2014

Decide whether/how to extend the networking model kubernetes/kubernetes#188

Closed

SvenDowideit reviewed Jul 18, 2014
View reviewed changes

vieux modified the milestones: 1.1.3, 1.3.0 Aug 22, 2014

crosbymichael removed this from the 1.3.0 milestone Sep 23, 2014

shykes closed this Nov 1, 2014

Conversation

vishh commented Jun 26, 2014

Uh oh!

vishh commented Jun 26, 2014

Uh oh!

vieux Jun 26, 2014

Choose a reason for hiding this comment

Uh oh!

vishh Jun 27, 2014

Choose a reason for hiding this comment

Uh oh!

vishh commented Jun 27, 2014

Uh oh!

crosbymichael commented Jun 27, 2014

Uh oh!

vishh commented Jun 27, 2014

Uh oh!

crosbymichael commented Jun 28, 2014

Uh oh!

vishh commented Jun 28, 2014

Uh oh!

tianon commented Jun 28, 2014

Uh oh!

SvenDowideit commented Jun 30, 2014

Uh oh!

vishh commented Jun 30, 2014

Uh oh!

vishh commented Jun 30, 2014

Uh oh!

vishh commented Jul 1, 2014

Uh oh!

vieux commented Jul 2, 2014

Uh oh!

fkautz commented Jul 8, 2014

Uh oh!

SvenDowideit commented Jul 8, 2014

Uh oh!

vishh commented Jul 11, 2014

Uh oh!

vishh commented Jul 16, 2014

Uh oh!

SvenDowideit Jul 18, 2014

Choose a reason for hiding this comment

Uh oh!

fredlf commented Jul 18, 2014

Uh oh!

vishh commented Jul 18, 2014

Uh oh!

tristanz commented Aug 12, 2014

Uh oh!

vishh commented Aug 12, 2014

Uh oh!

erikh commented Aug 12, 2014

Uh oh!

tristanz commented Aug 12, 2014

Uh oh!

shykes commented Nov 1, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants