Standardize api keys to CamelCase#6130
Merged
crosbymichael merged 2 commits intomoby:masterfrom Jun 2, 2014
Merged
Conversation
Docker-DCO-1.1-Signed-off-by: Victor Vieux <[email protected]> (github: vieux)
Docker-DCO-1.1-Signed-off-by: Victor Vieux <[email protected]> (github: vieux)
Contributor
|
LGTM |
2 similar comments
Contributor
|
LGTM |
Contributor
|
LGTM |
crosbymichael
added a commit
that referenced
this pull request
Jun 2, 2014
Standardize api keys to CamelCase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1011
Instead of dumping JSON, we now select which keys we want to send.
Right now I put the same as before, all the exported variables but with the keys in CamelCase.
If you think we should hide some keys from inspect, now is the time to say so :) @crosbymichael @unclejack
This is a
"breaking"change. I used""because we say to people not to rely to much on inspect as it might break :) Hopefully with this change, I'll become more stable.We didn't break compatibility, if you hit with
/v.1.11or lower, you'll get the old keys. /cc @discordianfish 😄