Invert flags#5760
Conversation
Docker-DCO-1.1-Signed-off-by: Victor Vieux <[email protected]> (github: vieux)
|
ping @SvenDowideit @shykes |
|
much ❤️ Docs LGTM |
Docker-DCO-1.1-Signed-off-by: Victor Vieux <[email protected]> (github: vieux)
|
@tianon typo updated |
|
ping @shykes @crosbymichael @creack |
|
Hmm, why? It is pretty painful to write |
|
@creack see #5545, @SvenDowideit is confused by |
|
This is a conflict between documentation and usability. Having to manually specify the value to the flag really makes usability worse. |
|
With #5764 that I did on top of this one, using |
|
@vieux and @creack yes - the confusion I'm talking about is in how the help for the option is laid out, not so much the actual usage. Specifically, read Its even more amusing, given that if someone reads the entire line as a single sentence, it becomes very true again - IFF you ignore the braces: Using |
|
I agree - that fugly syntax was my first-pass attempt to show whether we're enabled or disabled by default. I think swapping that to |
|
The motivation seems to be to solve #5545. However that issue is really about clarity of the usage message, Since breaking a flag is always extra work and complication, we should only do it if there's a strong |
Close #5545
--no-trunc=false->--trunc=true--no-cache=false->--cache=true--no-stdin=false->--stdin=true