import sha512 to make sha512 ssl certs work#5600
Merged
vieux merged 1 commit intomoby:masterfrom May 5, 2014
Merged
Conversation
Docker-DCO-1.1-Signed-off-by: Cristian Staretu <[email protected]> (github: unclejack)
Contributor
|
LGTM |
Contributor
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
vieux
added a commit
that referenced
this pull request
May 5, 2014
import sha512 to make sha512 ssl certs work
|
Awesome, thanks for doing this. I was working on it myself last night but didn't finish before I had to sleep 👍 |
Closed
|
Quick note for reference: Apparently sha384 certificates are also dependent on "import sha512". I'm using PositiveSSL which has: And getting this from "docker login": Go docs say "Package sha512 implements the SHA384 and SHA512 hash algorithms as defined in FIPS 180-2." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tiny PR makes Docker work with private registries which use SSL certs which use sha512 for hashing.
Fixes #5173.