Skip to content

Conversation

@vieux
Copy link
Contributor

@vieux vieux commented May 1, 2014

#5532 doesn't work with #5529

ping @tianon

This reverts commit fa1e390.

Docker-DCO-1.1-Signed-off-by: Victor Vieux <[email protected]> (github: vieux)
@crosbymichael
Copy link
Contributor

boom

@tianon
Copy link
Member

tianon commented May 1, 2014

YOU LIED TO ME???

@tianon
Copy link
Member

tianon commented May 1, 2014

There's gotta be a generic solution to this. Other people dind a lot too, even on Ubuntor.

@tianon
Copy link
Member

tianon commented May 1, 2014

could we maybe check in IsEnabled to see if the place apparmor_parser tries to write is readable by us?

@tianon
Copy link
Member

tianon commented May 1, 2014

s/readable/writable/

@crosbymichael
Copy link
Contributor

will not work

@tianon
Copy link
Member

tianon commented May 1, 2014

Elaborate!

@vieux
Copy link
Contributor Author

vieux commented May 1, 2014

@tianon I want to say it all started by a1a9baf

@crosbymichael
Copy link
Contributor

apparmor should not run within a container, weird stuff happens

@tianon
Copy link
Member

tianon commented May 1, 2014

Sure @vieux, blame me for trying to make the world a better place. :)

@crosbymichael
Copy link
Contributor

yes, this is really @tianon 's fault from the start

@tianon
Copy link
Member

tianon commented May 1, 2014

So if apparmor shouldn't be run in a container, why not set "container" universally? (yes, let's rehash that debate)

I think this is a workaround at best, and kind of an ugly one.

@crosbymichael
Copy link
Contributor

i thought the consensus was if you need to depend on container=whatever just use -e to add it

@tianon
Copy link
Member

tianon commented May 1, 2014

So everyone doing dind now has to add "container=..." for some docker-specific switch?

@vieux
Copy link
Contributor Author

vieux commented May 1, 2014

everyone

@vieux
Copy link
Contributor Author

vieux commented May 1, 2014

btw I agree with you @tianon but I have no other idea

Docker-DCO-1.1-Signed-off-by: Victor Vieux <[email protected]> (github: vieux)
@tianon
Copy link
Member

tianon commented May 1, 2014

LGTM

@tianon
Copy link
Member

tianon commented May 1, 2014

I can live with this solution, at least for now. :)

@tianon
Copy link
Member

tianon commented May 1, 2014

(especially since if it's in hack/dind, it's in the "canonical location" for information about dind)

@unclejack
Copy link
Contributor

LGTM

1 similar comment
@crosbymichael
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants