integration/daemon: TestLiveRestore remove quote from test-name#52310
Merged
AkihiroSuda merged 1 commit intomoby:masterfrom Apr 5, 2026
Merged
integration/daemon: TestLiveRestore remove quote from test-name#52310AkihiroSuda merged 1 commit intomoby:masterfrom
AkihiroSuda merged 1 commit intomoby:masterfrom
Conversation
Names of tests are used as storage location for test-results, and using a quote in the test-name resulted in CI failing to collect the results. Commit 07a5e92 updated a grammar issue in a sub-test, introducing a quote; ```patch - t.Run("engine restart shouldnt kill alive containers", func(t *testing.T) { + t.Run("engine restart shouldn't kill alive containers", func(t *testing.T) { ``` Which caused CI to fail when collecting the files: find bundles -path '*/root/*overlay2' -prune -o -type f \( -name '*-report.json' -o -name '*.log' -o -name '*.out' -o -name '*.prof' -o -name '*-report.xml' \) -print | xargs sudo tar -czf /tmp/reports.tar.gz [...] xargs: unmatched single quote; by default quotes are special to xargs unless you use the -0 option We should make collecting reports less brittle, and probably consider having some extra handling for the storage locations, but let's start with changing this test name. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/testing
kind/bugfix
AkihiroSuda
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xargs: unmatched single quote; by default quotes are special to xargs unless you use the -0 option#52300Names of tests are used as storage location for test-results, and using a quote in the test-name resulted in CI failing to collect the results. Commit 07a5e92 updated a grammar issue in a sub-test, introducing a quote;
Which caused CI to fail when collecting the files:
We should make collecting reports less brittle, and probably consider having some extra handling for the storage locations, but let's start with changing this test name.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)