api/types/network: fix handling of unmapped ports (ephemeral ports)#52288
Merged
thaJeztah merged 1 commit intomoby:masterfrom Apr 2, 2026
Merged
api/types/network: fix handling of unmapped ports (ephemeral ports)#52288thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
commit 4c24542 changed `PortRange.All()` to omit zero values for ports, but this caused a regression; the zero-value is used in some places to assign an ephemeral port, e.g.: `--port 80` is an implicit `--port 0:80`, or `--port <ephemeral port>:80`, where the daemon picks a random port number from the ephemeral port range as host-port. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
area/api
thaJeztah
commented
Apr 2, 2026
Comment on lines
-281
to
+282
| assert.Check(t, slices.Equal(slices.Collect(pr.All()), []network.Port{})) | ||
| var ephemeralPort network.Port | ||
| assert.Check(t, slices.Equal(slices.Collect(pr.All()), []network.Port{ephemeralPort})) |
Member
Author
There was a problem hiding this comment.
FWIW; I think we should look if we can just make this work; this fix means that an empty port-range requires at least 1 zero-value in it? Perhaps we could/should ultimately also make it work with an empty slice, but I need to look at the CLI side (which discarded the range if it's empty), so for now this seems like the safest bet.
vvoland
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit 4c24542 changed
PortRange.All()to omit zero values for ports, but this caused a regression; the zero-value is used in some places to assign an ephemeral port, e.g.:--port 80is an implicit--port 0:80, or--port <ephemeral port>:80, where the daemon picks a random port number from the ephemeral port range as host-port.- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)