Fix typos and misspellings in comments, tests, and docs#52277
Merged
thaJeztah merged 1 commit intomoby:masterfrom Apr 3, 2026
Merged
Fix typos and misspellings in comments, tests, and docs#52277thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
github-actions
Bot
added
area/logging
area/docs
area/testing
area/swarm
area/volumes
nvsahana
force-pushed
the
fix-typos-comments
branch
from
08c213c to
ae7d1fa
Compare
thaJeztah
requested changes
Apr 2, 2026
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
Thanks! Left one suggestion; also could you remove the "body" from the commit message? It's very verbose, and doesn't add real value; for typo-fixes, just a title is usually enough;
Fix typos and misspellings in comments, tests, and docs
- Fix various spelling mistakes found across the codebase using codespell:
-
- - daemon/daemon.go: multipler -> multiplier
- - daemon/cluster/convert/network.go: suppplied -> supplied (x2)
- - daemon/images/image.go: desserializing -> deserializing
- - daemon/cluster/executor/container/executor.go: wil -> will
- - daemon/kill.go: didnt -> didn't
- - daemon/migration_test.go: thats -> that's (x2)
- - daemon/cluster/controllers/plugin/controller_test.go: cancelation -> cancellation
- - daemon/logger/loggerutils/logfile_test.go: randome -> random
- - client/image_import.go: mutiple -> multiple
- - client/service_logs.go: ths -> the
- - client/task_logs.go: ths -> the
- - contrib/otel/README.md: buiding -> building
- - integration/volume/mount_test.go: servives -> survives
- - integration-cli/docker_api_swarm_service_test.go: 3nd -> 3rd (x2)
- - integration/daemon/daemon_test.go: shouldnt -> shouldn't
- - pkg/pools/pools_test.go: writter -> writer
- - pkg/plugins/pluginrpc-gen/parser.go: exected -> expected
Signed-off-by: Sahana Narasipura Vasudevarao <[email protected]>| }, | ||
| { | ||
| name: "gd with an image thats no longer available", | ||
| name: "gd with an image that's no longer available", |
Member
There was a problem hiding this comment.
Perhaps we should use a slightly shorter name for this; this is also used as part of the test name;
=== RUN TestContainerMigrateOS/gd_with_an_image_that's_no_longer_availableWhich can also be used to filter which tests to run, making the ' a bit more tricky to specify (either escape or quote);
go test -v -run TestContainerMigrateOS/c8d_with_an_image_that\'s_no_longer_available
=== RUN TestContainerMigrateOS
=== RUN TestContainerMigrateOS/c8d_with_an_image_that's_no_longer_available
--- PASS: TestContainerMigrateOS (0.00s)
--- PASS: TestContainerMigrateOS/c8d_with_an_image_that's_no_longer_available (0.00s)
...
go test -v -run "TestContainerMigrateOS/c8d_with_an_image_that\'s_no_longer_available"
=== RUN TestContainerMigrateOS
=== RUN TestContainerMigrateOS/c8d_with_an_image_that's_no_longer_available
--- PASS: TestContainerMigrateOS (0.00s)
--- PASS: TestContainerMigrateOS/c8d_with_an_image_that's_no_longer_available (0.00s)Maybe something like;
name: "gd with missing image",| }, | ||
| { | ||
| name: "c8d with an image thats no longer available", | ||
| name: "c8d with an image that's no longer available", |
Member
There was a problem hiding this comment.
Same for this one;
name: "c8d with missing image",
nvsahana
force-pushed
the
fix-typos-comments
branch
from
ae7d1fa to
faeb315
Compare
Contributor
Author
|
Done! Shortened the test names and trimmed the commit message body. |
Member
|
Thanks! Yes, some commit messages must be long to describe details that may not be clear from the diff itself, but for typo fixes it's the reverse; the diff itself should be self explanatory 😅 |
thaJeztah
reviewed
Apr 2, 2026
| } | ||
| if p := formatPlatform(options.Platform); p != "unknown" { | ||
| // TODO(thaJeztah): would we ever support mutiple platforms here? (would require multiple rootfs tars as well?) | ||
| // TODO(thaJeztah): would we ever support multiple platforms here? (would require multiple rootfs tars as well?) |
Member
There was a problem hiding this comment.
oh! I just realise this is touching a file in the client module; you probably need to run hack/vendor.sh to re-vendor the file (as it's a dependency for the moby v2 module, which uses vendoring)
Signed-off-by: Sahana Narasipura Vasudevarao <[email protected]>
nvsahana
force-pushed
the
fix-typos-comments
branch
from
faeb315 to
07a5e92
Compare
thaJeztah
added
kind/refactor
Member
|
Failures are unrelated |
This was referenced Apr 5, 2026
Member
(Narrator voice) to past me: they actually .... were related #52300 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fixed 20 spelling mistakes across 17 files in the codebase, found using
codespell.How I did it
Ran
codespellacross the repo (excluding vendor directories), manually verified each finding to exclude false positives, and corrected only clear misspellings.Changes
daemon/daemon.godaemon/cluster/convert/network.go(x2)daemon/images/image.godaemon/cluster/executor/container/executor.godaemon/kill.godaemon/migration_test.go(x2)daemon/cluster/controllers/plugin/controller_test.godaemon/logger/loggerutils/logfile_test.goclient/image_import.goclient/service_logs.goclient/task_logs.gocontrib/otel/README.mdintegration/volume/mount_test.gointegration-cli/docker_api_swarm_service_test.go(x2)integration/daemon/daemon_test.gopkg/pools/pools_test.gopkg/plugins/pluginrpc-gen/parser.goHow to verify it
All changes are in comments, string literals in tests, and documentation - no functional code is affected.
Description for the changelog
Fix various typos and misspellings in comments, tests, and documentation.