client/pkg/jsonmessage: add DisplayStream and DisplayMessages utils#52273
Merged
vvoland merged 2 commits intomoby:masterfrom Apr 1, 2026
Merged
client/pkg/jsonmessage: add DisplayStream and DisplayMessages utils#52273vvoland merged 2 commits intomoby:masterfrom
vvoland merged 2 commits intomoby:masterfrom
Conversation
thaJeztah
added
status/2-code-review
kind/enhancement
These can replace the existing DisplayJSONMessagesStream and DisplayJSONMessages functions, not requiring the caller to perform terminal detection. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
jsonmessage_utils
branch
from
ccd849b to
333f39c
Compare
vvoland
reviewed
Apr 1, 2026
| defer res.Close() | ||
|
|
||
| buf := &strings.Builder{} | ||
| assert.NilError(t, err) |
Contributor
There was a problem hiding this comment.
nit, this can be removed, not for this PR though
Suggested change
| assert.NilError(t, err) |
Member
Author
There was a problem hiding this comment.
Doh! I think I saw that one when I was working on this, but then ... forgot.
We should have a linter for that 🤔
vvoland
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These can replace the existing DisplayJSONMessagesStream and DisplayJSONMessages functions, not requiring the caller to perform terminal detection.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)