client: New: ignore nil-Opt instead of panicking#52184
Merged
thaJeztah merged 1 commit intomoby:masterfrom Mar 17, 2026
Merged
Conversation
thaJeztah
added
status/2-code-review
kind/bugfix
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
client_nil_ops
branch
from
1505d23 to
da4a638
Compare
thaJeztah
changed the title
vvoland
approved these changes
Mar 17, 2026
Contributor
vvoland
left a comment
vvoland
left a comment
There was a problem hiding this comment.
Do we need a changelog entry?
Member
Author
|
Not sure if we strictly need; I think it's a minor bug-fix; people would already have discovered if they passed a |
Member
Author
|
well; guess it wouldn't hurt either; added one, but fine to skip if it's not important enough 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)