api, client: add //go:fix inline directives to deprecated functions#52178
Merged
thaJeztah merged 4 commits intomoby:masterfrom Mar 20, 2026
Merged
api, client: add //go:fix inline directives to deprecated functions#52178thaJeztah merged 4 commits intomoby:masterfrom
thaJeztah merged 4 commits intomoby:masterfrom
Conversation
thaJeztah
added
status/2-code-review
kind/enhancement
The linter has not been updated yet to recognize this directive. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This allows `go fix ./..` to automatically migrate legacy code. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This allows `go fix ./..` to automatically migrate legacy code. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Add an example package to verify the `//go:fix inline` comments work; some cases do not work (for which I opened tickets in the go issue tracker). Signed-off-by: Sebastiaan van Stijn <[email protected]>
austinvazquez
approved these changes
Mar 19, 2026
thaJeztah
added
impact/changelog
impact/go-sdk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go fix#52177go fixdoes not inline nested inlines golang/go#78164api, client: add //go:fix inline directives to deprecated functions
This allows (with limitations) users to automatically upgrade to the replacements (see https://go.dev/blog/inliner);
golanci-lint: gocheckcompilerdirectives: ignore "//go:fix"
The linter has not been updated yet to recognize this directive.
api/types/strslice: add //go:fix inline directives for deprecated type
This allows
go fix ./..to automatically migrate legacy code.client: add //go:fix inline directives to deprecated functions
This allows
go fix ./..to automatically migrate legacy code.add example for go fix
Add an example package to verify the
//go:fix inlinecommentswork; some cases do not work (for which I opened tickets in the
go issue tracker).
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)