daemon: include moby module version in version response#52170
daemon: include moby module version in version response#52170vvoland merged 4 commits intomoby:masterfrom
Conversation
github-actions
Bot
added
area/builder
| // If the module is replaced (for example via go.work or replace directives), | ||
| // or no usable version information is available, Version returns an empty string. |
There was a problem hiding this comment.
This doesn't match the implementation. When module is replaced, the replaced version is returned, not empty string.
There was a problem hiding this comment.
moby/daemon/internal/mod/mod.go
Lines 70 to 72 in fd17027
vvoland
left a comment
vvoland
left a comment
There was a problem hiding this comment.
LGTM (assuming the implementation is correct, we can fix the comment in a follow up)
|
Good callout on the "replace" - it's probably still "ok" in most cases, but we hard-code the module name in the |
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Use the same implementation as is used in the client. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
2 participants
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)