Skip to content

ci: module-replace: ignore Dockerfile for api changes#52152

Merged
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:check_skip_dockerfile
Mar 10, 2026
Merged

ci: module-replace: ignore Dockerfile for api changes#52152
thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah:check_skip_dockerfile

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Mar 6, 2026

The API Dockerfile should be ok to ignore for this check, as it's not part of the module;

================================================
================================================
api diff:
-ARG GO_VERSION=1.25.7
+ARG GO_VERSION=1.25.8
================================================
Detected changes in ./api directory, checking for replace rule...
null
ERROR: Changes detected in ./api but go.mod is missing a replace rule for github.com/moby/moby/api
Please run ./hack/vendor.sh replace
================================================

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

The API Dockerfile should be ok to ignore for this check, as it's
not part of the module;

```
================================================
================================================
api diff:
-ARG GO_VERSION=1.25.7
+ARG GO_VERSION=1.25.8
================================================
Detected changes in ./api directory, checking for replace rule...
null
ERROR: Changes detected in ./api but go.mod is missing a replace rule for github.com/moby/moby/api
Please run ./hack/vendor.sh replace
================================================
```

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the check_skip_dockerfile branch from ff64831 to e064824 Compare March 6, 2026 13:58
@thaJeztah thaJeztah mentioned this pull request Mar 6, 2026
@thaJeztah thaJeztah merged commit ca59300 into moby:master Mar 10, 2026
54 checks passed
@thaJeztah thaJeztah deleted the check_skip_dockerfile branch March 10, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants