Skip to content

integration/image: pull ppc64le and s390x in TestSaveAndLoadPlatform#52119

Merged
vvoland merged 1 commit intomoby:masterfrom
ricardobranco777:saveload
Mar 5, 2026
Merged

integration/image: pull ppc64le and s390x in TestSaveAndLoadPlatform#52119
vvoland merged 1 commit intomoby:masterfrom
ricardobranco777:saveload

Conversation

@ricardobranco777
Copy link
Copy Markdown
Contributor

When savePlatforms is nil, ImageSave exports all platforms referenced in the image index. On ppc64le and s390x hosts, this includes the native platform which was never pulled, causing a "content digest not found" error.

Pull ppc64le and s390x alongside the other platforms so their content is available in the local store when the full-index save is attempted.

Otherwise we get this on ppc64le & s390x:

Failed
=== RUN   TestSaveAndLoadPlatform/With_no_platforms_specified
    save_test.go:338: assertion failed: error is not nil: Error response from daemon: unable to create manifests file: NotFound: content digest sha256:b3e2feab52cb0f1b09f58d171b74624f4a4c6176dd02280d14d104273d49eb12: not found

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

When savePlatforms is nil, ImageSave exports all platforms referenced
in the image index. On ppc64le and s390x hosts, this includes the
native platform which was never pulled, causing a "content digest not
found" error.

Pull ppc64le and s390x alongside the other platforms so their content
is available in the local store when the full-index save is attempted.

Signed-off-by: Ricardo Branco <[email protected]>
@vvoland
Copy link
Copy Markdown
Contributor

vvoland commented Mar 2, 2026

Thanks!

Technically this shouldn't be needed - it's caused by this bug: #50173 which makes the save error out if the native platform is not present.

Copy link
Copy Markdown
Contributor

@vvoland vvoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until #50173 is fixed this LGTM

@vvoland vvoland added the kind/bugfix PR's that fix bugs label Mar 5, 2026
@vvoland vvoland added this to the 29.3.0 milestone Mar 5, 2026
@vvoland vvoland merged commit 018cdea into moby:master Mar 5, 2026
165 of 166 checks passed
@ricardobranco777 ricardobranco777 deleted the saveload branch March 5, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/images Image Service area/testing kind/bugfix PR's that fix bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants