integration/container: Migrate TestAPIStatsNetworkStats to integratio…#52096
Open
deahtstroke wants to merge 1 commit intomoby:masterfrom
Open
Conversation
deahtstroke
force-pushed
the
50159-migrate-TestAPIStatsNetworkStats-from-integration-cli
branch
from
889245a to
8cfe545
Compare
thaJeztah
reviewed
Mar 15, 2026
| containertypes "github.com/moby/moby/api/types/container" | ||
| "github.com/moby/moby/client" | ||
| "github.com/moby/moby/v2/integration/internal/container" | ||
| "github.com/stretchr/testify/require" |
Member
There was a problem hiding this comment.
oh! can you use gotest.tools/v3 instead? We have stretchr as dependency (for one package IIRC), but use gotest.tools for everything else 😅
github-actions
Bot
added
area/builder
deahtstroke
force-pushed
the
50159-migrate-TestAPIStatsNetworkStats-from-integration-cli
branch
3 times, most recently
from
d97ead5 to
9791acc
Compare
Author
|
I accidentally pull changes without the |
…n suite Signed-off-by: Daniel Villavicencio <[email protected]>
deahtstroke
force-pushed
the
50159-migrate-TestAPIStatsNetworkStats-from-integration-cli
branch
from
9791acc to
919e946
Compare
Author
|
Just rebased on latest master to keep the branch up to date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Migrated the test TestAPIStatsNetworkStats to integration/ from the integration-cli/ suite in reference to epic #50159.
Please Note:
This is a copy of my other PR. I mistakingly did an interactive rebase when updating my branch to be up to date and it got very messy, so I thought it'd be best to just close the original and start another one. Nothing has changed. Apologies, I'm still new to using
rebasingon my normal workflow.- How I did it
Using test on integration-cli/docker_api_stats_test.go and slightly tweaking it to use the go-client instead of the direct CLI.
- How to verify it
Run using the integration test directive in the makefile:
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)
