Skip to content

ci: update docker/github-builder to v1#51964

Merged
vvoland merged 1 commit intomoby:masterfrom
crazy-max:update-github-builder
Jan 30, 2026
Merged

ci: update docker/github-builder to v1#51964
vvoland merged 1 commit intomoby:masterfrom
crazy-max:update-github-builder

Conversation

@crazy-max
Copy link
Copy Markdown
Member

@crazy-max crazy-max commented Jan 29, 2026

GitHub Builder is now tagged.

We would need backport to branches using old github-builder-experimental repo because redirects don't look supported for reusable workflows 😞

This was referenced Jan 29, 2026
Merged
Merged
Merged
Merged
thaJeztah
thaJeztah reviewed Jan 29, 2026
View reviewed changes
Comment thread .github/workflows/bin-image.yml
build:
if: ${{ github.event_name != 'pull_request' || !contains(github.event.pull_request.labels.*.name, 'ci/validate-only') }}
uses: docker/github-builder-experimental/.github/workflows/bake.yml@7643588149117bf0ca3a906caa3968c70484027a
uses: docker/github-builder/.github/workflows/bake.yml@v1
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1 is a tag? or does github actions resolve it to v1.x.x tags?

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh it's an actual tag; so how does that work if there's a v1.0.1, would the v1 then be re-tagged?

Copy link
Copy Markdown
Member Author

@crazy-max crazy-max Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes would be re-tagged similar to how GitHub Actions are released in the ecosystem.

Copy link
Copy Markdown
Member Author

@crazy-max crazy-max Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or does github actions resolve it to v1.x.x tags?

GitHub had a feature like this but it got delayed/abandoned https://github.com/actions/publish-immutable-action

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, right; yeah, because re-tagging seems to ugly. Github resolving to latest tag seems much saner

Copy link
Copy Markdown
Member Author

@crazy-max crazy-max Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also maybe we could consider immutable releases https://docs.github.com/en/code-security/concepts/supply-chain-security/immutable-releases and drop v1 tag, I will check with @tonistiigi

Copy link
Copy Markdown
Member

@tonistiigi tonistiigi Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we should fully drop v1 but I think we should recommend immutable releases or digests.

@crazy-max crazy-max mentioned this pull request Jan 29, 2026
Merged
thaJeztah
thaJeztah approved these changes Jan 29, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Jan 29, 2026

hm these are not related, right, or are they?

Error: An error has occurred while creating the zip file for upload
Error: EACCES: permission denied, open '/tmp/reports/otel-trace.jsonl'
/home/runner/work/_actions/actions/upload-artifact/v6/dist/upload/index.js:3899
    throw new Error('An error has occurred during zip creation for the artifact');
    ^

Error: An error has occurred during zip creation for the artifact
    at Archiver.zipErrorCallback (/home/runner/work/_actions/actions/upload-artifact/v6/dist/upload/index.js:3899:11)
    at Archiver.emit (node:events:520:35)
    at Archiver.<anonymous> (/home/runner/work/_actions/actions/upload-artifact/v6/dist/upload/index.js:23773:12)
    at __webpack_modules__.86454.module.exports.handleStuff (/home/runner/work/_actions/actions/upload-artifact/v6/dist/upload/index.js:35216:5)
    at Object.onceWrapper (node:events:622:28)
    at DeflateCRC32Stream.emit (node:events:520:35)
    at endReadableNT (node:internal/streams/readable:1701:12)
    at process.processTicksAndRejections (node:internal/process/task_queues:89:21)

@crazy-max
Copy link
Copy Markdown
Member Author

crazy-max commented Jan 29, 2026

hm these are not related, right, or are they?

Doesn't seem to relate no. Main error is https://github.com/moby/moby/actions/runs/21497069016/job/61934665352?pr=51964#step:7:529

@vvoland vvoland added this to the 29.2.1 milestone Jan 30, 2026
@vvoland vvoland merged commit ea7fa92 into moby:master Jan 30, 2026
176 of 180 checks passed
@crazy-max crazy-max deleted the update-github-builder branch January 30, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonistiigi tonistiigi tonistiigi left review comments

@thaJeztah thaJeztah thaJeztah approved these changes

@vvoland vvoland vvoland approved these changes

Assignees

No one assigned

Labels

area/ci

Projects

None yet

Milestone

29.2.1

Development

Successfully merging this pull request may close these issues.

4 participants

@crazy-max @thaJeztah @tonistiigi @vvoland