Skip to content

Dockerfile: update integration-cli CLI to v25.0.5#51187

Merged
vvoland merged 1 commit intomoby:masterfrom
thaJeztah:bump_test_cli
Oct 31, 2025
Merged

Dockerfile: update integration-cli CLI to v25.0.5#51187
vvoland merged 1 commit intomoby:masterfrom
thaJeztah:bump_test_cli

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

Now that we're raising the minimum API version, we can also update the CLI used in our integration-cli tests.

- What I did

- How I did it

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah thaJeztah added this to the 29.0.0 milestone Oct 14, 2025
@thaJeztah thaJeztah force-pushed the bump_test_cli branch 5 times, most recently from 8a5eb06 to 885c585 Compare October 17, 2025 10:02
@github-actions github-actions Bot added the area/daemon Core Engine label Oct 17, 2025
@vvoland
Copy link
Copy Markdown
Contributor

vvoland commented Oct 17, 2025

cli.WithEnvironmentVariables("DOCKER_API_VERSION=v1.46"), // FIXME(thaJeztah): integration-cli runs docker CLI 18.06; we're "upgrading" the API version to a version it doesn't support here ;)

This comment needs update too! 😄

@thaJeztah
Copy link
Copy Markdown
Member Author

BuildKit sets a zero-date for "from scratch" images, so randomizing the order because of that;

=== FAIL: amd64.integration-cli TestDockerCLIImagesSuite/TestImagesFilterSinceAndBefore (32.40s)
    docker_cli_images_test.go:157: assertion failed: false (bool) != true (true bool): SINCE filter: Image list is not in the correct order: [sha256:327ff5da6c6108abd1bd994fa84b5773dacaaac681fe4b4a60df262a071eda3d sha256:04f228ee241d04a1ab585922d7cda024d2bf0702fe2276a7418996ab9d44a52f]
        REPOSITORY   TAG       IMAGE ID       CREATED        SIZE
        image        3         327ff5da6c61   55 years ago   0B
        image        1         d0bc8e875e1d   55 years ago   0B
        image        2         04f228ee241d   55 years ago   0B
        
    --- FAIL: TestDockerCLIImagesSuite/TestImagesFilterSinceAndBefore (32.40s)

@thaJeztah thaJeztah force-pushed the bump_test_cli branch 3 times, most recently from 6d3e377 to 01bc11b Compare October 31, 2025 02:14
Now that we're raising the minimum API version, we can also update
the CLI used in our integration-cli tests.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah marked this pull request as ready for review October 31, 2025 10:22
@thaJeztah thaJeztah requested a review from tianon as a code owner October 31, 2025 10:22
@vvoland vvoland merged commit 3287abc into moby:master Oct 31, 2025
181 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants